[Added pgsql-hackers to CC:]

Michael Glaesemann wrote:
[ a patch for constraint trigger docs]

Great! I was just going to try to use constraint triggers (because I needed deferrable constraints). So I personally appreciate this documentation update very much.

Just some notes:

Index: doc/src/sgml/ref/create_constraint.sgml
...
--- 21,32 ----
   <refsynopsisdiv>
  <synopsis>
CREATE CONSTRAINT TRIGGER <replaceable class="parameter">name</replaceable>
!     AFTER <replaceable class="parameter">event [ OR ... ]</replaceable>
!     ON <replaceable class="parameter">table_name</replaceable>
! [ FROM <replaceable class="parameter">referenced_table_name</replaceable> ] ! { NOT DEFERRABLE | [ DEFERABBLE ] { INITIALLY IMMEDIATE | INITIALLY DEFERRED } }
!     FOR EACH ROW
! EXECUTE PROCEDURE <replaceable class="parameter">funcname</replaceable> ( <replaceable class="parameter">arguments</replaceable> )
  </synopsis>
   </refsynopsisdiv>

It's spelled DEFERRABLE. You got it right in NOT DEFERRABLE but wrong in [ DEFERABBLE ].

> The name of the constraint trigger. The actual name of the
> created trigger will be of the form
> <literal>RI_ConstraintTrigger_0000<literal> (where 0000 is some number
> assigned by the server). Use this assigned name is when dropping the
> constraint.

It think you should drop the "is" from the last sentence here. Additionally, I would prefer "Use this assigned name when dropping the trigger." here, because this one confused me to try to "ALTER TABLE DROP CONSTRAINT" instead of "DROP TRIGGER".

Thanks again.

Best Regards,
Michael Paesold


---------------------------(end of broadcast)---------------------------
TIP 1: if posting/reading through Usenet, please send an appropriate
      subscribe-nomail command to [EMAIL PROTECTED] so that your
      message can get through to the mailing list cleanly

Reply via email to