I've realized that Peter's criticism (concerning comparing beginning
of datum with "<?xml") is right: current approach is unable to work
with XML values such as "<?xml ...?><a /><b />".

I'll propose a modification of the patch as long as fixes for NULLs as
input and output values very soon (in a day or so).

On 4/4/07, Nikolay Samokhvalov <[EMAIL PROTECTED]> wrote:
The patch attached contains following changes:
   1. The function name xmlpath() is changed to xpath();
   2. Approach of passing of namepspace mappings to the function is changed:
now that array (the 3rd argument) should be a 2-dimentional array with the
length of the second axis = 2 (e.g., ARRAY[ARRAY['a1', 'http://a1'],
ARRAY['a2', 'http://a2'], ARRAY['a2', 'http://a2']]);
   3. Description of xpath() function in docs (I'm sorry for possible
mistakes in English and docbook formatting, please check it...)


On 4/3/07, Bruce Momjian <[EMAIL PROTECTED]> wrote:
> Nikolay Samokhvalov wrote:
> > On 3/22/07, Peter Eisentraut < [EMAIL PROTECTED]> wrote:
> > > Bruce Momjian wrote:
> > > > Patch applied.
> > >
> > > This code seems to think that if an xml datum starts with "<?xml" it's
a
> > > document.  That is completely bogus.
> >
> > Agreed. I'll fix it.
>
> Nikolay, it has been a week, and I have see no fixes from you in
> response to requests from Peter.  If the patch doesn't arrive in 1-2
> days, I will have to revert your patch and it will be kept for 8.4.
> Feature freeze was April 1, 2007.
>
> --
>   Bruce Momjian  <[EMAIL PROTECTED]>          http://momjian.us
>   EnterpriseDB
http://www.enterprisedb.com
>
>   + If your life is a hard drive, Christ can be your backup. +
>



--
Best regards,
Nikolay



--
Best regards,
Nikolay

---------------------------(end of broadcast)---------------------------
TIP 7: You can help support the PostgreSQL project by donating at

               http://www.postgresql.org/about/donate

Reply via email to