Your patch has been added to the PostgreSQL unapplied patches list at: http://momjian.postgresql.org/cgi-bin/pgpatches
It will be applied as soon as one of the PostgreSQL committers reviews and approves it. --------------------------------------------------------------------------- Jaime Casanova wrote: > On 3/17/07, Tom Lane <[EMAIL PROTECTED]> wrote: > > "Jaime Casanova" <[EMAIL PROTECTED]> writes: > > > On 3/5/07, Tom Lane <[EMAIL PROTECTED]> wrote: > > >> In the second place, it's a serious violation of what little modularity > > >> and layering we have for fd.c to be calling into commands/tablespace.c. > > >> This is not merely cosmetic but has real consequences: one being that > > >> it's now unsafe to call OpenTemporaryFile outside a transaction. > > > > > ok, you are right... what do you suggest? > > > maybe move the GetTempTablespace function to somewhere in > > > src/backend/utils? > > > > You missed the point entirely. Relocating the code to some other file > > wouldn't change the objection: the problem is that fd.c mustn't invoke > > any transactional facilities such as catalog lookups. It's too low > > level for that. > > > > You could perhaps do it the other way around: some transactional > > code (eg the assign hook for a GUC variable) tells fd.c to save > > some private state controlling future temp file creations. > > > > ok. i have done that. > I know this is not the time i told you but i was busy at job. > > i haven't did anything about RemovePgTempFiles() yet, because i want > to know of the posibility of getting this on 8.3 > > -- > regards, > Jaime Casanova > > "Programming today is a race between software engineers striving to > build bigger and better idiot-proof programs and the universe trying > to produce bigger and better idiots. > So far, the universe is winning." > Richard Cook [ Attachment, skipping... ] > > ---------------------------(end of broadcast)--------------------------- > TIP 9: In versions below 8.0, the planner will ignore your desire to > choose an index scan if your joining column's datatypes do not > match -- Bruce Momjian <[EMAIL PROTECTED]> http://momjian.us EnterpriseDB http://www.enterprisedb.com + If your life is a hard drive, Christ can be your backup. + ---------------------------(end of broadcast)--------------------------- TIP 7: You can help support the PostgreSQL project by donating at http://www.postgresql.org/about/donate