Tomas Doran wrote: > > On 7 May 2007, at 23:25, Neil Conway wrote: > > >On Mon, 2007-07-05 at 19:48 +0100, Tomas Doran wrote: > >>As suggested in the TODO list (and as I need the functionality > >>myself), I have implemented the current_query interface to > >>debug_query_string.
FWIW I think you should still provide dblink_current_query, even if it's only a wrapper over current_query(), for backwards compatibility. Also, typically we don't remove items from the TODO list. We mark them as "done" prepending them with a dash. Patch authors are not expected to do it either (though I don't see it be a problem if they did). > Also done, note OID has changed as I was having conflicts (template1 > wouldn't build). Should I either pick something else unused which is > lower (is there anything?), move current_query to the end of the file > or just leave it be.. Doesn't matter ... just make sure duplicate_oids doesn't report a problem. unused_oids is useful to find, err, unused OIDs. > >* AFAIK debug_query_string() still does the wrong thing when the user > >submits multiple queries in a single protocol message (separated by > >semi-colons). Not sure there's a way to fix that that is both easy and > >efficient, though... > > Should that be added to the TODO list? Probably ... -- Alvaro Herrera http://www.CommandPrompt.com/ The PostgreSQL Company - Command Prompt, Inc. ---------------------------(end of broadcast)--------------------------- TIP 4: Have you searched our list archives? http://archives.postgresql.org
