-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Fri, Apr 18, 2008 at 2:37 AM, Tom Lane  wrote:
>  The function names in the patch need schema-qualification in case
>  pg_catalog is not first in the search path.
>

Ah, yes.  I should have seen that.  Thanks Tom.

New version attached with schema-qualification.

Cheers,
BJ
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (GNU/Linux)
Comment: http://getfiregpg.org

iD8DBQFIB4Ae5YBsbHkuyV0RAqJVAJ9+h6wZrLT9YFRw3s2E742sg7Yr4wCgvtcq
xK7cTnbiGtfpGGYw5WP4asI=
=hf8W
-----END PGP SIGNATURE-----
*** src/bin/psql/describe.c
--- src/bin/psql/describe.c
***************
*** 482,488 **** permissionsList(const char *pattern)
                                          "SELECT n.nspname as \"%s\",\n"
                                          "  c.relname as \"%s\",\n"
                                          "  CASE c.relkind WHEN 'r' THEN '%s' 
WHEN 'v' THEN '%s' WHEN 'S' THEN '%s' END as \"%s\",\n"
!                                         "  c.relacl as \"%s\"\n"
                                          "FROM pg_catalog.pg_class c\n"
           "     LEFT JOIN pg_catalog.pg_namespace n ON n.oid = 
c.relnamespace\n"
                                          "WHERE c.relkind IN ('r', 'v', 
'S')\n",
--- 482,488 ----
                                          "SELECT n.nspname as \"%s\",\n"
                                          "  c.relname as \"%s\",\n"
                                          "  CASE c.relkind WHEN 'r' THEN '%s' 
WHEN 'v' THEN '%s' WHEN 'S' THEN '%s' END as \"%s\",\n"
!                                         "  
pg_catalog.array_to_string(c.relacl, chr(10)) as \"%s\"\n"
                                          "FROM pg_catalog.pg_class c\n"
           "     LEFT JOIN pg_catalog.pg_namespace n ON n.oid = 
c.relnamespace\n"
                                          "WHERE c.relkind IN ('r', 'v', 
'S')\n",
*** src/test/regress/expected/dependency.out
--- src/test/regress/expected/dependency.out
***************
*** 68,86 **** NOTICE:  CREATE TABLE / PRIMARY KEY will create implicit index 
"deptest_pkey" fo
  GRANT ALL ON deptest1 TO regression_user2;
  RESET SESSION AUTHORIZATION;
  \z deptest1
!                                                           Access privileges 
for database "regression"
!  Schema |   Name   | Type  |                                                  
       Access privileges                                                        
  
! 
--------+----------+-------+------------------------------------------------------------------------------------------------------------------------------------
!  public | deptest1 | table | 
{regression_user0=arwdxt/regression_user0,regression_user1=a*r*w*d*x*t*/regression_user0,regression_user2=arwdxt/regression_user1}
  (1 row)
  
  DROP OWNED BY regression_user1;
  -- all grants revoked
  \z deptest1
!               Access privileges for database "regression"
!  Schema |   Name   | Type  |             Access privileges              
! --------+----------+-------+--------------------------------------------
!  public | deptest1 | table | {regression_user0=arwdxt/regression_user0}
  (1 row)
  
  -- table was dropped
--- 68,88 ----
  GRANT ALL ON deptest1 TO regression_user2;
  RESET SESSION AUTHORIZATION;
  \z deptest1
!                 Access privileges for database "regression"
!  Schema |   Name   | Type  |               Access privileges                
! --------+----------+-------+------------------------------------------------
!  public | deptest1 | table | regression_user0=arwdxt/regression_user0
!                            : regression_user1=a*r*w*d*x*t*/regression_user0
!                            : regression_user2=arwdxt/regression_user1
  (1 row)
  
  DROP OWNED BY regression_user1;
  -- all grants revoked
  \z deptest1
!              Access privileges for database "regression"
!  Schema |   Name   | Type  |            Access privileges             
! --------+----------+-------+------------------------------------------
!  public | deptest1 | table | regression_user0=arwdxt/regression_user0
  (1 row)
  
  -- table was dropped
-- 
Sent via pgsql-patches mailing list (pgsql-patches@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-patches

Reply via email to