! int
  pthread_mutex_init(pthread_mutex_t *mp, void *attr)
  {
        *mp = CreateMutex(0, 0, 0);
+       if (*mp == NULL)
+               return 1;
+       return 0;
  }

Maybe it would be better to emulate what pthreads does. Instead of returing 1 to indicate an error, return an errno. In the above case, ENOMEM seems like a good fit.

Also, maybe you should check the passed in mutex pointer. If its NULL, you could return EINVAL.

--
Andrew Chernow
eSilo, LLC
every bit counts
http://www.esilo.com/

--
Sent via pgsql-patches mailing list (pgsql-patches@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-patches

Reply via email to