On Fri, 2008-07-04 at 19:38 +0100, Dave Page wrote: > On Fri, Jul 4, 2008 at 5:20 PM, Simon Riggs <[EMAIL PROTECTED]> wrote: > > > > * If the patch was implemented as an ExplainOneQuery_hook we would be > > able to use this with 8.3 also, which might be interesting. So there's > > no real need for this to be a patch on core. > > Would that mean that instead of being an optional format that pgAdmin > could request with appropriate grammar, it would be something that was > only available if the plugin was loaded, and would replace regular > EXPLAIN output? If so, that would be extremely inconvenient, and next > to useless for general purpose utilities.
It can be optional since plugins can add parameters also. It wouldn't take long to make up a plugin for 8.3 once this patch has been committed to core for 8.4, so if you're saying you'd definitely like it in core then I'm OK with that. -- Simon Riggs www.2ndQuadrant.com PostgreSQL Training, Services and Support -- Sent via pgsql-patches mailing list (pgsql-patches@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-patches