Le 06/06/2013 10:33, Marcus Denker a écrit :
On Jun 6, 2013, at 10:25 AM, Goubier Thierry <thierry.goub...@cea.fr> wrote:
Le 06/06/2013 08:32, Marcus Denker a écrit :
On Jun 5, 2013, at 4:10 PM, Goubier Thierry <thierry.goub...@cea.fr> wrote:
Le 05/06/2013 16:04, Marcus Denker a écrit :
On Jun 5, 2013, at 4:03 PM, Goubier Thierry <thierry.goub...@cea.fr> wrote:
Le 05/06/2013 15:56, Marcus Denker a écrit :
On Jun 5, 2013, at 2:39 PM, no-re...@ci.inria.fr wrote:
https://ci.inria.fr/pharo/job/Pharo-2.0-Tests/./Run=run%201,VM=vm,label=linux/247/
3 regressions found.
FileSystem.Tests.Disk.FileHandleTest.testTruncate
Refactoring.Tests.Changes.RBRefactoringChangeTests.testPerformChangeComment
Tests.Monticello.MCClassDefinitionTest.testLoadAndUnload
Ok, so we have 2 independent issues;
1) testTruncate failing on recent Ubuntu in both 2.0 and 3.0
https://pharo.fogbugz.com/f/cases/10852
2) The slice I integrated was wrong / not complete:
FileSystem.Tests.Disk.FileHandleTest.testTruncate
Refactoring.Tests.Changes.RBRefactoringChangeTests.testPerformChangeComment
https://pharo.fogbugz.com/f/cases/10415
For this, I think the best would be to submit the missing code in some machine
readable form
as I right now am a bit confused about what exactly "adding the right flush
methods" means.
As far as I can browse,
SLICE-Issue-10411-flush-after-nextChunkPut-ThierryGoubier.1 contains the
correct code.
When I merge it in 2.0 606 I do not see any change..
Do you want me to retry generating a slice?
Maybe something is wrong with the image that was used to run the tests? Maybe
that one actually was 605?
Marcus
I recreated a work image (20605), tested and saw the two failures:
FileSystem.Tests.Disk.FileHandleTest.testTruncate
Refactoring.Tests.Changes.RBRefactoringChangeTests.testPerformChangeComment
Then loaded SLICE-Issue-10411-flush-after-nextChunkPut-ThierryGoubier.1
(the changes are visible :))
And ended with those two tests green.
(But with
Refactoring.Tests.Changes.RBRefactoringChangeTests.tesValidTraitComposition(|2|3|4)
failures)
Now, 606 isn't available, no? I use get.pharo.org/20
Thierry
--
Thierry Goubier
CEA list
Laboratoire des Fondations des Systèmes Temps Réel Embarqués
91191 Gif sur Yvette Cedex
France
Phone/Fax: +33 (0) 1 69 08 32 92 / 83 95
