On 24 Oct 2013, at 13:55, Torsten Bergmann <asta...@gmx.de> wrote:

> From the comments I think we can agree that it is a better to have a lint rule
> instead of breaking things the way it was introduced by the original issue 
> #11876. 
>  
> I therefore opened an issue 
>   
> https://pharo.fogbugz.com/f/cases/11989/shouldnt-raise-Error-from-issue-11876-is-too-offensive
> and uploaded a slice 
>  
>   
> SLICE-Issue-11989-shouldntraise-Error-from-issue-11876-is-too-offensive-TorstenBergmann.1
>  
> to Pharo30Inbox on STHub (http://smalltalkhub.com/mc/Pharo/Pharo30Inbox/main) 
> that
> removed #validateShouldntException: 
>  
> I used a fresh 3.0 image (Pharo3.0 Latest update: #30519)
>  
> Please test so it can be integrated and we can continue to focus on more 
> interesting stuff.

With respect to Seaside (and its cross-platform-ness), this is probably a good 
decision, for now.

But it is fundamentally unfair to call this an arbitrary unimportant change 
meant to annoy people. On the contrary ! I even think that there are too many 
methods in TAssertable and the #shouldnt: checks are very confusing and are 
candidates for removal, IMHO. Too much unnecessary code is not good in the long 
run.

Have you ever written a #shouldnt: test ? I have never done so !

I took a Seaside image and looked at the senders of #shouldnt: and friends. 
There are that many from Seaside and I haven’t seen any good example that could 
not be written otherwise.

My 2c.

Sven

> Thanks
> Torsten
>  
>  
>  


Reply via email to