Ben Coman wrote:
I am requesting that the following fix be integrated.
https://pharo.fogbugz.com/f/cases/13065/Windows-FileSystem-test-bar-not-an-absolute-path

This corrects semantics on Windows where '/tmp/bar/'  is not considered an absolute path name, so that gets located under the image directory rather than the root directory of C-drive.  Its been review by Nicolai on Windows and Max on OSX..

The following fix is dependent on it.  This one is fairly minor - just updating a test that is not picked up by the Monkey running on Linux since it only fails on Windows due to differences in platform specific parts.  It would be good to deliver the Release with no failing tests.
https://pharo.fogbugz.com/f/cases/12911/MetacelloRepositorySqueakCommonTestCase-failing-in-fresh-image-on-Windows

In case https://pharo.fogbugz.com/f/cases/13030/Many-tests-failing-in-MetacelloValidation-Job-on-Jenkins
Nicolai notes:
> There are some other Windows path related problems like comparing
> '/opt/aPath/aFile' ~= (WindowsWorkingDirectory)\aPath\aFile.
> We have to find a way to compare the (OS-Filesystem-Independent)-AbsolutePaths instead.

This requirement is facilitated by Case 13065.

cheers -ben 
Thanks Marcus.   Case 12911 is ready to go.  Its now a real simple change, and low impact being only a test.   Could someone do a final review to get it over the line.

cheers, Ben

Reply via email to