2014-08-07 14:42 GMT+02:00 Camille Teruel <camille.ter...@gmail.com>:
> > On 7 août 2014, at 14:26, Nicolai Hess <nicolaih...@web.de> wrote: > > Yes, that are may changes. > > I think I was a bit confused about > showHierarchy : show the real hierarchy of an class > and > showHierarchy : show the classes in a package sorted hierarchically. > > The first one is enabled by the hierarchy/flat-Button (show packages) > The second one is enabled by a "showhierarch" setting > > > You see I was unaware of the setting :) > BTW, it doesn't change the way classes are displayed when I disable it. > Yes, when I changed the implementation in ClassList I wasn't aware on this, so this is broken too. But I woking on it :) > > > 2014-08-07 13:47 GMT+02:00 Camille Teruel <camille.ter...@gmail.com>: > >> Hi everyone, >> >> I noticed that browsing Object take several seconds (5s on my machine). >> Evaluate Nautilus openOnClass: Object. >> After profiling, I found it's because of >> ClassWidget>>setCachedHierarchyClass: that calls SortHierarchically >> class>>buildHierarchyForClasses: with a big collection of classes. >> But the browser opens on the package view by default, not the hierarchy >> view. >> So if I replace: >> >> ClassWidget>>showHierarchy: anObject >> showHierarchy := anObject. >> self selectedClass ifNotNil:[: class | >> self setCachedHierarchyClass: class] >> by: >> >> ClassWidget>>showHierarchy: aBoolean >> (showHierarchy := aBoolean) >> ifTrue: [ self selectedClass ifNotNil: [ :class | self >> setCachedHierarchyClass: class] ] >> >> it solves the problem. >> But I don't know that part of the system well and I don't know if it's >> the correct thing to do or if we should try to improve performances of >> SortHierarchically instead. >> So tell me what you think about it. >> Here is the bug entry: >> https://pharo.fogbugz.com/f/cases/13795/Browsing-certain-classes-takes-several-seconds >> >> >> Thanks, >> Camille >> > > >
