> On 22 Apr 2015, at 15:59, Johan Fabry <jfa...@dcc.uchile.cl> wrote: > > Hola, > > It looks like a really cool tool! I just added it to my LRP development image > and I plan on using it full time. I am always interested in writing cleaner > code.
Thanks :) > > So expect comments from me :-) Actually I already have one: > > For one class I got the critic ‘References an abstract class’ and 'Subclass > responsibility not defined’. Excellent that you found it, but now I have to > go through all the methods of the class to see where the first critic comes > from, and through all methods of all leaf classes for the second one. :-( :-( > :-( That’s a lot of work for me to rescue some information which apparently > the tool already knows. Please add more information on where the issue is on > these kinds of errors, so I can fix them more easily … Yes, this is the major issue with SmallLint. If you are interested in details here it goes: for example "References an abstract class” is defined to work on a class, and it’s definitely easier to check whether the class is abstract and has any references than taking a method getting all class references and checking is any class is abstract. But as the result you get a critic about the class and not about the methods that access it. Right now I’m analyzing Small Lint rules to see what issues they have and understanding how to approach the problem. Maybe some temporary hack will be possible for certain rules, otherwise it will be fixed when I get to improving the Small Lint. Nevertheless your feedback is very important, as I get to know what the real issues are. Cheers, Uko > > Thanks and keep up the good work! > >> On Apr 22, 2015, at 03:58, Yuriy Tymchuk <yuriy.tymc...@me.com >> <mailto:yuriy.tymc...@me.com>> wrote: >> >> Hi everyone! >> >> Probably most of you know, that I am developing a tool called >> QualityAssistant, which displays current critics about your code in >> SystemBrowser, Inspector and Spotter. >> >> I’m happy to tell you that there is a new release v0.4 which does not >> require you to do any previous setup! Just load it from configuration >> browser (pharo 4 & 5) and it will start giving you feedback. More details >> can be found here: >> https://github.com/Uko/QualityAssistant#quality-assistant-beta- >> <https://github.com/Uko/QualityAssistant#quality-assistant-beta->. If you >> are upgrading from older version, it is recommended to load QualityAssistant >> into a fresh image, because multiple announcement and process changes may >> cause exceptions in old objects. >> >> Even if you are an experienced programmer you can find QualityAssistant >> useful for instantly spotting typos or making sure that you didn’t forget >> some details about your code. >> >> Please give me a feedback about your experience, as I want to make it even >> more useful. Either write me an email, or open an entry at: >> https://github.com/Uko/QualityAssistant/issues >> <https://github.com/Uko/QualityAssistant/issues> >> >> Have a nice week! >> Uko >> >> <critics.jpg> >> _______________________________________________ >> Moose-dev mailing list >> moose-...@iam.unibe.ch <mailto:moose-...@iam.unibe.ch> >> https://www.iam.unibe.ch/mailman/listinfo/moose-dev > > > > ---> Save our in-boxes! http://emailcharter.org <http://emailcharter.org/> > <--- > > Johan Fabry - http://pleiad.cl/~jfabry <http://pleiad.cl/~jfabry> > PLEIAD lab - Computer Science Department (DCC) - University of Chile >
