Thanks nicolai for all these questions.
Writing more tests is cool. I started and each time alain imporved Bloc :)
Alain is driving somwhere in vacation with nearly no internet.
Stef
BlAlarmQueue
- split into two classes?
Queue : managing the add/remove/sort
Scheduler : process the Alarms
- alarm/alarmqueue both accessing and check the time "Time now"
I would put both checks to, either the alarm OR the queue/scheduler.
And don't use "Time now" explicit, if we put this behind a method
call, we
can easily create alarm queue mocs for unit tests.
- readding periodic alarms: shouldn't this be done by the alarm itself
- the queue should not care, whether a alarm is periodic.
Some alarm examples put the queue into the morphs property dictionary.
I could find out why
this is necessary.
Layout:
Box/Column/Row Layout and corresponding cells define a double linked
list, we already
have a DoubleLinkedList, can we use the DoubleLinkedList instead of
reimplmenting this
on the layout/cells?
Yes.
Tablelayout: is this "work in progress" or abandoned? Currently it
shares much code with
the BoxLayout, but it does not look like it is working.
I think that this is more a work in progress.
Theming:
#theme is a property of BlProtoView - isn't this to low level for
defining theming support?
How would you theme a CircleView or an ImageView?
Animation:
what are all these "Logics"?
animationLogic
toLogic
stepLogic and steppedLogic(!?)
ifLogic ....
I would really like to see if Viva animation could be used in Bloc.
StephaneDucasse / PetitsBazars
> viva
Alex used it for Roassal and this is nice but we need more experience
and to check if it is compatible with the design of bloc.
Is this a software pattern ? I have never seen this before.
(For example we use "sortBlock" but not "sortLogic").
How about ValueHolder or good old "Block".
And "ifLogic" sounds like a condition, why don't we name it. ...
condition?
And putting all this "logic" into one animation class scares me.
About the class comment syntax:
- is this pillar syntax? I think this is difficult to read. Do you use
that syntax, because we
want to use a pillar as comment text and build a renderer for this or
is it to share comments between class comments and the bloc doc book,
easily?
yes.
I can help with documenting the classes but I find it difficult to see
which parts of bloc
are just tests/proof of concept or are supposed to be in the final
version. Maybe I miss the big picture?
What I can tell is that I tried several times and bloc changed at that
time :)
Now it is ***much*** more stable so this is the time to push. Did you
read a bit the documentation we started on BlocCore?
So having tests would be nice.
I was planning to start to port some little classes I have around the
game such as ledMorph and other to see how it goes.
Stef
