Oh yes I know. I'm not saying that looking at the changes we would have spotted the problems. I'm just saying that I want to get the changes in textual format in my mail-box as in squeak because
it helps me understanding and knowing that something changed.
I'm digging in the Diffbuilder and friends to see but I have some other tasks to finish first.
Nautilus is a difficult beast, you all know. Even if you look close at the merge diff you may
miss some important relation that only really visible during debugging.
I did some test when reviewing this fix. But really, there are so many
ways do you need to consider
- different ways for opening nautilus
- navigate with keys and mouse
- selecting updating / changes from other browser and system changes.
- refactorings

It is really not that easy and I am happy that Franck and Yuri are actually trying to
improve Nautilus.
you can not easily tests all and make the changes and reviews bullet proof.


nicolai



    Hi,

    This is a side effect of

    
https://pharo.fogbugz.com/f/cases/16475/Nautilus-sends-too-many-announcements-for-a-single-action

    (which was reviewed by two people, so not obvious).

    What happened is that #updatePackageGroupAndClassList calls
    itself via #selectedClass: leading to a loop.

    Should be easy to fix for the people involved in case 16475.

       Marcus


    On Sat, Sep 5, 2015 at 8:51 AM, stepharo <steph...@free.fr
    <mailto:steph...@free.fr>> wrote:

        Hi

        I do not know if this is linked to recent changes but we
        cannot remove classes or move them to another package.

        Stef




-- --
    Marcus Denker  -- den...@acm.org <mailto:den...@acm.org>
    http://www.marcusdenker.de <http://www.marcusdenker.de/>




Reply via email to