Le 5/9/15 20:46, Peter Uhnák a écrit :
Just because looking at a patch isn't as powerful doesn't make it
useless. There are still benefits
* you are more aware of code changes
* you can still spot conceptual problems
* it's dead simple; the mail literally arrives at your doorsteps and
all you need to do is look
of course this isn't replacing proper review, but there is big still
value in it.
100% what I want to say. I will allocate time on a goodies that take a
slice and produce a diff
But even the "regular" process could be improved.
-> download the image before it was added
-> merge the slice.
For example I have startup script, that for images that have name
"issuenumber - verify" on startup automatically opens MCBrowser on the
slice so I can merge with two clicks.
(It's not automerged because I want to test behavior before and after
loading the slice.)
Since I'm mostly verifying my own fixes, I generally don't look at the
changesets, but maybe you could autoopen a diff or something...
Or even add a category to PharoLauncher "Pharo - To Review" so I
wouldn't even need to type in the issue number.
Peter
