Hi guys
I think that esteban will have some work to detress from FFI and Spur
hacking :).
Some random thoughts:
- We should have by default icon objects (and not their description and
the objects in the image) in the image
- We should not need to access github to get pharo running :)
-- icon description should be cached on the disc (I was teaching in a
place where there is no internet).
- Icons should probably also delivered modularly (a tool may want to
have specific button).
- Do not push changes like that the friday afternoon :)
Stef
Le 2/10/15 19:40, Torsten Bergmann a écrit :
The latest changes on ThemeIcons completely broke functionality and
icons of external and included packages.
1. Intelli J Icons are now used as default, but most icons of
external packages (Pomodoro, MongoTools, EventRecorder, ScriptManager, ....)
align with the eclipse icon set. Can we please stay with Eclipse as default
so that we do not have to introduce intelliJ icons on each external
project as well?
2. The mechanisms of ThemeIcons class do not work anymore. The icons in
Versionner are lost. Also other external package who extended ThemeIcons
(like DesktopManager) are now broken.
Just try to load it into a Pharo5.0 Latest update: #50359 now
3. Some of the icons are removed - for instance in catalog and moved to
be retrieved from Github. But we wanted to componentize the image
into configs. So the icons of catalog should belong to this project. Right?
4. I can not open the settings in the latest image anymore because the icons
are tried to retrieve from Github using a HTTPS connection.
Doesnt work either because I'm on Windows, because of HTTPs, because
ZnClient does not deal with a firewall correctly.
It is not good to rely on additional external downloads directly.
I know we want to make progress ... but were such changes discussed on the list
before?
Thx
T.
