On Tue, Dec 29, 2015 at 6:53 PM, Andrei Chis <chisvasileand...@gmail.com>
wrote:
> Of course. Feel free to commit as many improvements as you want :)
>
> Just what solution did you have in mind? Ideally the pane displaying
> setUp/tearDown should only be visible when those methods exist, but the
> structure of a tabulator browser in glamour cannot be changed dynamically.
>
>
Well...that's true. However, since so far we only have setUp and tearDown
tabs, I thought that for the time being I could simply change the condition
in #debuggerStructureIn: browser and #debuggerTransmissionsIn:. Then I
simply add the column if at least ANY of those 2 have implementation that
is not the one from TestCase.
Is this good enough for the time being?
> On Tue, Dec 29, 2015 at 10:41 PM, Mariano Martinez Peck <
> marianop...@gmail.com> wrote:
>
>> May I commit also the change to NOT render setUp/tearDown pane if both
>> implementations are the default one of TestCase?
>>
>> Thanks!
>>
>> On Tue, Dec 29, 2015 at 6:30 PM, Andrei Chis <chisvasileand...@gmail.com>
>> wrote:
>>
>>> Done
>>>
>>> On Tue, Dec 29, 2015 at 10:25 PM, Mariano Martinez Peck <
>>> marianop...@gmail.com> wrote:
>>>
>>>>
>>>>
>>>> On Tue, Dec 29, 2015 at 6:13 PM, Andrei Chis <
>>>> chisvasileand...@gmail.com> wrote:
>>>>
>>>>> Hi Mariano,
>>>>>
>>>>> I actually forgot about that change.
>>>>> I'll add it tomorrow. Or if you have time today you can do it; it
>>>>> should be exactly as in the Pharo 4 version.
>>>>>
>>>>>
>>>> I want to commit but I don't have access. Could you add me to the team
>>>> please?
>>>>
>>>> Thanks!
>>>>
>>>>
>>>>> Cheers,
>>>>> Andrei
>>>>>
>>>>> On Tue, Dec 29, 2015 at 10:03 PM, Mariano Martinez Peck <
>>>>> marianop...@gmail.com> wrote:
>>>>>
>>>>>> Hi Andrei,
>>>>>>
>>>>>> OK, the code loads correct now but I miss some changes you did back
>>>>>> for 4.0. Remember the change on
>>>>>>
>>>>>> textAttributesForStackEntry: aContext
>>>>>>
>>>>>> (self selectedContext isNil or: self class enableStackColoring not)
>>>>>> ifTrue: [ ^ {TextColor color: Smalltalk ui theme textColor} ].
>>>>>>
>>>>>> * ^ Smalltalk ui theme styleContext: aContext from: self.*
>>>>>>
>>>>>> Which would delegate to the theme? And then we have special method
>>>>>> for Pharo3DarkTheme.
>>>>>>
>>>>>> Is there a way to integrate that in the latest version too?
>>>>>>
>>>>>> Thanks!
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>> On Tue, Dec 29, 2015 at 2:48 PM, Andrei Chis <
>>>>>> chisvasileand...@gmail.com> wrote:
>>>>>>
>>>>>>> Hi Mariano,
>>>>>>>
>>>>>>> The code below loads GTDebugger and registers the extensions.
>>>>>>>
>>>>>>> Gofer it
>>>>>>> smalltalkhubUser: 'Moose' project: 'GToolkit';
>>>>>>> package: 'ConfigurationOfGTDebugger';
>>>>>>> load.
>>>>>>> (Smalltalk at: #ConfigurationOfGTDebugger) loadDevelopment.
>>>>>>> #GTGenericStackDebugger asClass register.
>>>>>>> #GTSUnitDebugger asClass register.
>>>>>>> #GTBytecodeDebugger asClass register.
>>>>>>> Smalltalk tools registerDebugger: SpecDebugger withRank: 2.
>>>>>>>
>>>>>>> Cheers,
>>>>>>> Andrei
>>>>>>>
>>>>>>>
>>>>>>> On Tue, Dec 29, 2015 at 11:16 AM, Andrei Chis <
>>>>>>> chisvasileand...@gmail.com> wrote:
>>>>>>>
>>>>>>>> I'm working now on a config for cleanly loading GTDebugger plus
>>>>>>>> SUnit and bytecode extensions into Pharo 5.
>>>>>>>> Hopefully it will be done by today or tomorrow.
>>>>>>>>
>>>>>>>> Cheers,
>>>>>>>> Andrei
>>>>>>>>
>>>>>>>> On Tue, Dec 29, 2015 at 2:49 AM, Mariano Martinez Peck <
>>>>>>>> marianop...@gmail.com> wrote:
>>>>>>>>
>>>>>>>>> I tried:
>>>>>>>>>
>>>>>>>>> Gofer it
>>>>>>>>> smalltalkhubUser: 'Moose' project: 'GToolkit';
>>>>>>>>> package: 'ConfigurationOfGTDebugger';
>>>>>>>>> load.
>>>>>>>>> (Smalltalk at: #ConfigurationOfGTDebugger) loadBleedingEdge.
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> but that loads a hell of stuff I don't want...and conflicts and..
>>>>>>>>>
>>>>>>>>> So.. how can I get simply GTDebugger with the SUnit extensions?
>>>>>>>>>
>>>>>>>>> Thanks in advance,
>>>>>>>>>
>>>>>>>>> --
>>>>>>>>> Mariano
>>>>>>>>> http://marianopeck.wordpress.com
>>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>
>>>>>>
>>>>>>
>>>>>> --
>>>>>> Mariano
>>>>>> http://marianopeck.wordpress.com
>>>>>>
>>>>>
>>>>>
>>>>
>>>>
>>>> --
>>>> Mariano
>>>> http://marianopeck.wordpress.com
>>>>
>>>
>>>
>>
>>
>> --
>> Mariano
>> http://marianopeck.wordpress.com
>>
>
>
--
Mariano
http://marianopeck.wordpress.com
