Revert the new API. It was mistake to integrate it in the code freeze phase.
-- Pavel 2016-11-14 9:53 GMT+01:00 Nicolai Hess <nicolaih...@gmail.com>: > > > 2016-11-14 9:42 GMT+01:00 Pavel Krivanek <pavel.kriva...@gmail.com>: > >> Well, we will revert the change >> >> > revert the autodeprecation or the new api ? > I made a fix for case 19336 Finder and FileList can now work with the new > api. > > >> -- Pavel >> >> 2016-11-13 17:33 GMT+01:00 Nicolai Hess <nicolaih...@gmail.com>: >> >>> >>> >>> 2016-11-13 10:06 GMT+01:00 Nicolai Hess <nicolaih...@gmail.com>: >>> >>>> >>>> >>>> 2016-11-11 10:55 GMT+01:00 Pavel Krivanek <pavel.kriva...@gmail.com>: >>>> >>>>> Hi, >>>>> >>>>> the API of Pragma was changed in quite dangerous way. >>>>> In past we had: >>>>> - #selector to access to method selector >>>>> - #keyword to access to pragma selector >>>>> >>>>> now we have: >>>>> - #methodSelector to access to method selector >>>>> - #selector to access to pragma selector >>>>> >>>>> That means that the meaning of the message #selector was changed and >>>>> it can cause some problems (like some currently failing tests [1]). The >>>>> #selector message was deprecated in the middle of the transition process >>>>> so >>>>> most of usages should be already rewritten to #methodSelector but we >>>>> need to be aware of it. >>>>> >>>>> [1] https://pharo.fogbugz.com/f/cases/19333/17-more-tests-fa >>>>> iling-due-to-MockSettings-class-Object-doesNotUnderstand-moc >>>>> ksystemsettings-SettingTreeBuilder-mocksystemse >>>>> >>>> >>>> And it broke finder. >>>> 19336 >>>> <https://pharo.fogbugz.com/f/cases/19336/Finder-broken-Can-not-search-for-pragmas> >>>> Finder broken: Can not search for pragmas >>>> >>> >>> And FileList can not show .cs files anymore. >>> I think both has something to do with a lock (?) during the transform of >>> the autodeprecation. >>> >>> >>>> >>>> >>>>> >>>>> Cheers >>>>> -- Pavel >>>>> >>>> >>>> >>> >> >
