I'm integrating 20307 and I would like to really thank you for - the bug entry description - all the comments - and tests in the PR.
Tx!!! On Tue, Aug 15, 2017 at 5:11 PM, Stephane Ducasse <stepharo.s...@gmail.com> wrote: > Tx for the information. I will focus on 20307 then > > > On Tue, Aug 15, 2017 at 11:07 AM, Alistair Grant <akgrant0...@gmail.com> > wrote: >> Hi Stef, >> >> On Tue, Aug 15, 2017 at 10:04:31AM +0200, Stephane Ducasse wrote: >>> tx a lot for the summary, this is super useful :) >>> I will over them later (because I must work on my new lectures :). >>> >>> Stef >> >> I've just realised that: >> >> - https://pharo.fogbugz.com/f/cases/20165/Support-segment-path-printing >> >> has merge conflicts, and that #20307 adds more merge conflicts. >> >> The easiest thing to do is to defer this issue until after #20307 has >> been merged. I'll then update the patch to remove the merge conflicts >> and resubmit. >> >> Cheers, >> Alistair >> >> >> >> >>> On Tue, Aug 15, 2017 at 7:58 AM, Alistair Grant <akgrant0...@gmail.com> >>> wrote: >>> > Hi Stef, >>> > >>> > I've added the PR to fix automatic canonicalisation of path references >>> > to the parent directory (".."): >>> > >>> > - >>> > https://pharo.fogbugz.com/f/cases/20307/File-names-should-not-be-canonicalised-by-default >>> > - https://github.com/pharo-project/pharo/pull/206 >>> > >>> > Other open issues (to help keep track): >>> > >>> > - https://pharo.fogbugz.com/f/cases/20165/Support-segment-path-printing >>> > - https://pharo.fogbugz.com/f/cases/18084/FileReference-EnsureCreateFile >>> > https://github.com/pharo-project/pharo/pull/133 >>> > - >>> > https://pharo.fogbugz.com/f/cases/19609/FileReference-base-should-be-before-last-separator >>> > https://github.com/pharo-project/pharo/pull/137 >>> > - >>> > https://pharo.fogbugz.com/f/cases/20294/Add-FileAttributesPlugin-to-the-linux-32-bit-VM >>> > This is the first step in fixing FileReference>>isSymlink and >>> > extending support for all file attributes returned by stat() and >>> > lstat(). >>> > The parent issue is: >>> > >>> > https://pharo.fogbugz.com/f/cases/18279/isSymlink-seems-to-be-broken-on-Linux >>> > >>> > >>> > Since #13217 has been accepted, #18042 and its associated PR should be >>> > closed (won't fix): >>> > >>> > - https://pharo.fogbugz.com/f/cases/18042 >>> > - https://github.com/pharo-project/pharo/pull/75 >>> > >>> > >>> > Thanks! >>> > Alistair >>> > >>> > >>> > >>> > On Thu, Aug 10, 2017 at 08:23:49PM +0000, Alistair Grant wrote: >>> >> Hi Stef, >>> >> >>> >> On Wed, Aug 09, 2017 at 10:12:17PM +0200, Stephane Ducasse wrote: >>> >> > Hi alistair >>> >> > >>> >> > I went on fogbugz to find the fix to be included and I'm not sure not >>> >> > that find them. >>> >> > I looked for FileSystem. >>> >> > >>> >> > I found >>> >> > - >>> >> > https://pharo.fogbugz.com/f/cases/20165/Support-segment-path-printing >>> >> > >>> >> > - >>> >> > https://pharo.fogbugz.com/f/cases/18084/FileReference-EnsureCreateFile >>> >> > https://github.com/pharo-project/pharo/pull/133 >>> >> > >>> >> > - >>> >> > https://pharo.fogbugz.com/f/cases/19609/FileReference-base-should-be-before-last-separator >>> >> > https://github.com/pharo-project/pharo/pull/137 >>> >> > >>> >> > Did I miss some others? >>> >> > >>> >> > Stef >>> >> >>> >> - >>> >> https://pharo.fogbugz.com/f/cases/20294/Add-FileAttributesPlugin-to-the-linux-32-bit-VM >>> >> This is the first step in fixing FileReference>>isSymlink and >>> >> extending support for all file attributes returned by stat() and >>> >> lstat(). >>> >> The parent issue is: >>> >> >>> >> https://pharo.fogbugz.com/f/cases/18279/isSymlink-seems-to-be-broken-on-Linux >>> >> >>> >> Just for completeness, the two issues relating to FileReference>>/: >>> >> >>> >> - >>> >> https://pharo.fogbugz.com/f/cases/13217/FS-basename-with-compound-path-string >>> >> - https://github.com/pharo-project/pharo/pull/192 >>> >> - https://pharo.fogbugz.com/f/cases/18042 >>> >> - https://github.com/pharo-project/pharo/pull/75 >>> >> >>> >> >>> >> Cheers, >>> >> Alistair >>> > >>> >>
