On Sat, 4 Aug 2018 at 15:43, Alistair Grant <akgrant0...@gmail.com> wrote: > > > > > I don't think the error handling has been changed in a long time, but > > just looking quickly at the source code, I think you're correct that it > > isn't returning the correct values. It should be returning nil for > > those handles that aren't valid. > > > > I don't have my Windows VM handy at the moment, is anyone able to > > quickly confirm? (Start pharo with Pharo.exe (not PharoConsole.exe) and > > supply the result from: > > > > File stdioHandles
This does indeed fail to return nil even though stdio is not available. Instead a sqFile handle with null HANDLE* is returned. But the image can't test this as the format of sqFile is platform dependent and is private to the VM. > > I've been asking lots of questions lately and not providing much input > > (I was hoping to have File Attributes integrated by now, but MacOS file > > encoding and my inability to get the VM to compile on a Mac VM have > > frustrated me), so I'm more than happy to tidy up the stdio primitives. > > > > I'll need to check that it doesn't break anything on Squeak as well > > (I don't think any of the changes discussed should cause problems). > > Tracking issue: https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/274 The issue above is for the VM changes. The issue for image changes is: https://pharo.fogbugz.com/f/cases/22296/Stdio-file-creation-fixes Cheers, Alistair
