thanks Sean I did not see that stefan did a pass too. So I will check the diff.
Stef > On 25 Mar 2019, at 16:41, Sean P. DeNigris <s...@clipperadams.com> wrote: > > Stéphane Ducasse wrote >> https://github.com/SquareBracketAssociates/Booklet-ManagingCode > > I submitted a comprehensive grammar pass. I just want to point out that this > was only possible due to the incredible amount of work people have done to > move us into the git/GH world. In the past, my experience was that > submitting a fix often took at least as long as doing the actual fixing (and > significantly longer for small fixes)! > > Past: > 1. save the packages individually > 2. Publish the code > a. if the repo allowed writing, put them there > b. if read-only, come up with some alternative, like creating your own > monolithic staging area repo, or other DIY solution > c. if the repo was abandoned, you'd probably be better off giving up and > finding a new profession, because you may end up manually copying the repo > with no API way to establish the link > 3. create a mailing list thread for discussion > 4. Wait and hope > > Present: > 1. Save all project changes in one step > 2. Click "Create PR" > Bonus #1: Go have a beer > Bonus #2: you can keep working with your new changes by loading from your > fork until the canonical accepts the PR > > So: /thank you/ to everyone involved in git/GH/Iceberg support!!! > > > > ----- > Cheers, > Sean > -- > Sent from: http://forum.world.st/Pharo-Smalltalk-Developers-f1294837.html >
