Maybe the best is to revert for now https://github.com/pharo-project/pharo/pull/5359 <https://github.com/pharo-project/pharo/pull/5359>
> On 11 Dec 2019, at 14:39, George Ganea <georgega...@gmail.com> wrote: > > Hi Vincent, > > In the end we tried it after it was merged :) Our CI uses the latest Pharo 8 > image. > Unfortunately we did not see an improvement, and even worse, it seems to > break one of our builds that is downstream from GToolkit. We got all sorts of > errors that seemed to be related to incomplete method code. > Two examples below. > > Syntax Error on line 2: ''']'' expected' > ======================================== > 1: privateState > 2: ^ privateState ifNil: [ p > > groupedByIntervalType: aTemporalIntervalType fromTimestamp: startTimestamp > toTimestamp: endTimestamp > ^ self > groupedByIntervalType: aTemporalIntervalType > inGroupOfType: self temporalGroupType > from: (aTemporalIntervalT')' expected -> > > We’ve now switched our CI to a fixed version image that is prior to this > merge. > Even though the code we’re loading is in a private repo, please let me know > if there is anything I can do to help debug this. > > Thank you, > George > >> On 6 Dec 2019, at 19:05, George Ganea <georgega...@gmail.com >> <mailto:georgega...@gmail.com>> wrote: >> >> Hi Vincent, >> >> I will definitely try it out and report back. >> >> Thank you! >> George >>> Hi Georges, >>> >>> There have been quite some improvements those last weeks on the performance >>> of loading classes and methods. But we are still waiting for the >>> https://github.com/pharo-project/pharo/pull/5292 >>> <https://github.com/pharo-project/pharo/pull/5292> to be integrated. >>> >>> And you have to encapsulate the loading code into: SourceFiles >>> deferFlushDuring: [...] and use the latest pharo 8.0 image. >>> >>> You can give a try with this and tell us how it goes! >>> >>> Cheers, >>> Vincent >>> >>> -----Original Message----- >>> From: Pharo-dev On Behalf Of George Ganea >>> Sent: Friday, 6 December 2019 17:08 >>> To: pharo-dev at lists.pharo.org >>> <http://lists.pharo.org/mailman/listinfo/pharo-dev_lists.pharo.org> >>> Cc: Chis Vasile Andrei <dedal18 at yahoo.com >>> <http://lists.pharo.org/mailman/listinfo/pharo-dev_lists.pharo.org>> >>> Subject: [Pharo-dev] code loading performance >>> >>> Hi all, >>> >>> Currently loading GToolkit takes quite some time (arount 18 minutes at the >>> best of times) we were wondering if there’s been any attempts at improving >>> code loading times in Metacello/Monticello. Or mabye there are some ideas >>> on how one might start doing something like this? >>> >>> Cheers, >>> George >> >