http://lists.gforge.inria.fr/pipermail/pharo-project/2008-June/000323.html
[Pharo-project] MVC removal step2 investigations
This is a big removal. I reviewed the code. Here are my comments:
- Few methods in Browser are redefined using the hypothesis that a
browser cannot be open in an MVC project. Methods that refer to
PluggableButtonView are also removed. This make sense since this class
can be considered as obsolete: a PluggableButtonView cannot be open
anymore.
- ChangeList: optionalButtonsView is removed. This makes sense since
it opens MVC button (PluggableButtonView). This method is called nowhere
- ChangeSorter>>openView: topView offsetBy: offset is removed. This
method is called nowhere, and refers to MVC code
Few questions:
- Inspector>>openOn: anObject withEvalPane: withEval withLabel: label
valueViewClass: valueViewClass seems to be called by FormInspectView
class>>openOn: aFormDictionary withLabel: aLabel
Don't you think that removing this method might be a problem?
- Why have you removed PasteUpMorph>>open ?
TestRunner me dit:
- Avant le removal: 2117 run, 2108 passes, 2 expected failures, 7
failures, 0 errors, 0 unexpected passes
- Après le removal: 2068 run, 2059 passes, 2 expected failures, 7
failures, 0 errors, 0 unexpected passes
Je n'ai vu aucun problème après avoir chargé le removal.
I favour an inclusion.
Cheers,
Alexandre
--
_,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:
Alexandre Bergel http://www.bergel.eu
^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.
_______________________________________________
Pharo-project mailing list
Pharo-project@lists.gforge.inria.fr
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
