Lukas, i stumbled upon a strange behavior using the refactoring engine.
 
When adding a method, the precondition checks if the class or any super class 
defines the method to be added.

It must only ask if the class directly defines it.

The fix is

AddMethodRefactoring>>preconditions
        | selector method |
        method := RBParser parseMethod: source
                                onError: 
                                        [:string :position | 
                                        ^RBCondition 
                                                withBlock: [self 
refactoringError: 'The sources could not be parsed']].
        selector := method selector.
        selector isNil ifTrue: [self refactoringError: 'Invalid source.'].
        ^(RBCondition definesSelector: aSelector in: aClass : selector in: 
class) 


Could you please modfify this in the package you maintain? 

Of course, only  if you think this fix is correct!

Saludos,
Fernando


_______________________________________________
Pharo-project mailing list
[email protected]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project

Reply via email to