Status: Accepted
Owner: [email protected]
Labels: Importance-Low

New issue 3876 by [email protected]: SqNumberParserTest>>testFloatGradualUnderflow has an odd condition
http://code.google.com/p/pharo/issues/detail?id=3876

SqNumberParserTest>>testFloatGradualUnderflow has an odd condition:

In the following code, note that #areLowercaseDigitsAllowed is expected to return nil or notNil:

"Parse the number in base 16 if possible - it is impossible if lowercase letter are allowed digits
         due to exponent letter ambiguity."
        float := self areLowercaseDigitsAllowed
                ifNil: [SqNumberParser parse: '16r2.D2593D58B4FC4e-256']
                ifNotNil: [trueFraction asFloat].

but #areLowercaseDigitsAllowed returns true or false and in the 1.2 image it returns true ... implying that is impossible to parse?

As it stands the `trueFraction asFloat` expression is always executed ... I'm trying to port SqNumberParser to GemStone and this little section of code is misleading, especially considering that GemStone doesn't pass the test:)


Reply via email to