On Sun, Jan 27, 2013 at 01:11:07AM +0800, Ben Coman wrote: > David T. Lewis wrote: > >On Sat, Jan 26, 2013 at 08:50:43AM +0800, Ben Coman wrote: > > > >>David T. Lewis wrote: > >> > >>>Unit test notes: > >>> > >>>The AioEventHandlerTestCase failures are due to AioPlugin not included in > >>>the VM. I expect the tests will pass if AioPlugin is added to VM builds. > >>> > >>> > >>Just general curiosity, is there a way to have a test queued to run > >>first which tests for the plug-in, and if it fails the remaining tests > >>become "expected failures" rather than "failures". > >> > > > >Yes, you could do this by implementing #expectedFailures to check for the > >plugin and answer a different set of selectors depending on what it finds. > > > >It all depends on what you mean by an "expected failure". To me, failing > >to find the plugin is not an expected failure. > > Failing to find the plugin should not be an expected failure, but then > all subsequent tests are expected to fail and are just noise. Actually > the recent post on 'test dependencies' in Phexample looks like a good > way to do this. >
Now I understand what you mean. You're right. Personally I don't mind seeing all of the tests that are impacted by a problem like this, but I agree it's mostly noise at that point. Dave
