Very good Cami. I have two remarks. If it should be short I think that

curl -sL get.pharo.org  | bash

is shorter than

wget --quiet -O - get.pharo.org | bash 

If I see it correct the script is used for CI but as there is a get.pharo.org 
host I assume it is supposed to be an easy entry point for all kind of users, 
right?

If this is true I find it somewhat strange to have a 
download-all-in-one-and-cozy-script that downloads everything needed but to 
start it I have still to provide the image myself to the shell scripts. So I 
added this to the script

# parse vm options and image
for arg in "$@"
do
   if [[ $arg == -* ]];
   then
      VMOPTIONS="$VMOPTIONS $arg"
      shift
   else
      break
   fi
done
IMAGE=$1
shift
# if no image has been provided use the installed one
if [ -z "$IMAGE" ];
then
   IMAGE=$DIR/Pharo.image
fi

which uses the downloaded image in case nothing has been specified on the 
commandline.

Hope you like it. Usually I would extract the same portion of both scripts to 
an extra file but then there is the trade-off to have one more file in the 
download. I'll attach a version of vm-ui.sh for you to try. If you need help 
I'm happy to chime in for this.

thanks for the effort,

Norbert

Attachment: vm-ui.sh
Description: Binary data


Am 02.04.2013 um 09:15 schrieb Camillo Bruni <camillobr...@gmail.com>:

> we're back up, shinier than ever ;)
> 
> check http://get.pharo.org ;)
> 
> now you can use:
>       wget --quiet -O - get.pharo.org | bash 
> for the current stable release of Pharo and the PharoVM.
> 
> On 2013-04-01, at 22:52, Tudor Girba <tu...@tudorgirba.com> wrote:
>> No stress. In the worst case you can fix it tomorrow during the tutorial :).
>> 
>> Doru
>> 
>> 
>> On Apr 1, 2013, at 10:26 PM, Camillo Bruni <camillobr...@gmail.com> wrote:
>> 
>>> 
>>> On 2013-04-01, at 22:09, "Sean P. DeNigris" <s...@clipperadams.com> wrote:
>>> 
>>>> Tudor Girba-2 wrote
>>>>> Could it have something to do with the latest optimizations of Camillo?
>>>> 
>>>> Probably... Cami breaks everything :-P
>>> 
>>> dammit, I wanted to silently add the new zeroconf scripts
>>> obviously something went horribly wrong there, sorry guys.. working on it!
>>> 
>> 
>> --
>> www.tudorgirba.com
>> 
>> "What is more important: To be happy, or to make happy?"
>> 
>> 
> 
> 

Reply via email to