Hi Stani, I see you haven't committed the crop action yet. Any more changes you want me to do to it?
Best Regards, Nadia On Fri, Jun 12, 2009 at 12:18 AM, Nadia Alramli <[email protected]> wrote: > Hi, > > This was a tough one, but I hope I succeeded. Now it is possible to >> show/hide fields conditionally. The method is very simple. Just add a >> get_relevant_field_labels() method to the Action. It is very important >> that the list of labels has EXACTLY the same order as defined in the >> interface method. >> I've implemented for these actions already: >> modified phatch/actions/color_to_alpha.py >> modified phatch/actions/crop.py >> modified phatch/actions/save.py >> modified phatch/actions/watermark.py > > Thanks for doing this! this feature is very important for usability. > > >> Try them out and see if you can find any bugs! Note that the update >> will only take place after the field lost focus by clicking somewhere >> else or moving your mouse away over the toolbar. > > I find this a bit confusing. Is there a technical reason to only change > when losing focus? > > >> >> This opens a lot of nice possibilities. Please go through the actions >> and see which ones could profit from this. From now on there should >> not any field be shown which is not relevant. This means that for some >> actions we need to add a ChoiceField which shows/hide the other >> fields. This is for example the case for the rounded corners action. >> It also might allow for more actions to add extra options. >> >> Nadia, the crop action still need some (important) work. I added to >> the white board of the blueprint: >> https://blueprints.launchpad.net/phatch/+spec/crop-action > > No problem, check the attached action :) > > Best Regards, > Nadia > > >> >> >> Best regards, >> >> Stani >> >> -- >> Phatch Photo Batch Processor - http://photobatch.stani.be >> SPE Python IDE - http://pythonide.stani.be >> >> _______________________________________________ >> Mailing list: >> https://launchpad.net/~phatch-dev<https://launchpad.net/%7Ephatch-dev> >> Post to : [email protected] >> Unsubscribe : >> https://launchpad.net/~phatch-dev<https://launchpad.net/%7Ephatch-dev> >> More help : https://help.launchpad.net/ListHelp >> > >
_______________________________________________ Mailing list: https://launchpad.net/~phatch-dev Post to : [email protected] Unsubscribe : https://launchpad.net/~phatch-dev More help : https://help.launchpad.net/ListHelp
