Hi Juho,
Phatch is compatible with py2.4 so do not use:
condition = condition if condition else always_true
With multiple if statements, it is better to use elif.
photo.metadata is just a buffer for changed metadata values, so your patch
won't work even not for "All'. It surprises me it did for you.
You'll have to lookup photo.info for possible metatags, as metadata
should be empty by default unless some action modified metadata. It is
better to use regular expressions, as otherwise for the 'All' method you
need to check two conditions.
I rewrote your action and pushed it in the trunk.
** Changed in: phatch
Importance: Undecided => Medium
** Changed in: phatch
Status: New => Fix Committed
** Changed in: phatch
Assignee: (unassigned) => stani (stani)
--
Implementation of "Delete Tags"
https://bugs.launchpad.net/bugs/386772
You received this bug notification because you are a member of Phatch
Developers, which is subscribed to Phatch.
Status in Phatch = Photo & Batch!: Fix Committed
Bug description:
Implementation of
https://blueprints.launchpad.net/phatch/+spec/delete-tag-action .
Note that I have not tested it thorougly though "All" option seemed to work
just fine and hopefully rest do too.
_______________________________________________
Mailing list: https://launchpad.net/~phatch-dev
Post to : [email protected]
Unsubscribe : https://launchpad.net/~phatch-dev
More help : https://help.launchpad.net/ListHelp
