I agree, add what you have in now along with a comment about improvements that also need doing, so they won't get forgotten.

Andrei Alexandrescu wrote:
Perfect. Thank you!

Andrei

Steve Schveighoffer wrote:
Yes, it's me.

Through discussion with Sean, the changes will be added (I will post it within the next couple days). I need to recreate the patch with the newest druntime directory structure. It's my fault it's not in yet, Sean told me he would add it late january, but I was on vacation the first week of Feb, and the last week has been very busy for me.

There is still the issue of the special functions that append a dchar to a char or wchar array. I don't have the typeinfo passed in so I cannot tell whether the array is shared or not. However, I think it's better to add what I have now and worry about fixing shared stuff later (I'm pretty sure shared is not done exactly correct right now). I haven't had time to read the latest installment of tdpl, but I'm confident that we can solve the problems of shared array appending later. Fixing the stomping problem is important to get out there for people to play with.

-Steve



----- Original Message ----
From: Andrei Alexandrescu <[email protected]>
To: Discuss the phobos library for D <[email protected]>; Steven Schveighoffer <[email protected]>
Sent: Wed, February 17, 2010 11:05:31 AM
Subject: Re: [phobos] array appending changes to druntime

Steve was working on this. Steve, did you commit your changes to phobos? (I think Steve is on the list, but I'm adding him just to be sure.)

Andrei

Walter Bright wrote:
This TDPL book example still fails:

unittest {
int[] a = [0, 10, 20, 30, 40, 50, 60, 70];
auto b = a[4 .. $];
a = a[0 .. 4];
// At this point a and b are adjacent
a ~= [0, 0, 0, 0];
assert(b == [40, 50, 60, 70]); // passes; a got reallocated
}



because the agreed upon array append changes to druntime haven't been done
yet. I can't recall who was doing that, or indeed if anyone had taken responsibility for getting it done.
_______________________________________________
phobos mailing list
[email protected]
http://lists.puremagic.com/mailman/listinfo/phobos



      _______________________________________________
phobos mailing list
[email protected]
http://lists.puremagic.com/mailman/listinfo/phobos
_______________________________________________
phobos mailing list
[email protected]
http://lists.puremagic.com/mailman/listinfo/phobos


_______________________________________________
phobos mailing list
[email protected]
http://lists.puremagic.com/mailman/listinfo/phobos

Reply via email to