On 4/14/2016 9:35 AM, Jonathan M Davis via phobos wrote:
If we don't test it, we won't catch when the code is wrong due to a change in Microsoft's time zone info. But the fact that it changes so frequently like this is precisely why that functionality has been deprecated in favor of reading the conversion data in from a file, thereby leaving it up to the programmer to make sure that the data is up-to-date. I think that it's quite clear that hardcoding it as I did originally has proven to be a bad idea. Unfortunately, it'll be a while before those functions are done with the deprecation cycle and removed, so we have to continue to deal with Microsoft's random changes until then. - Jonathan M Davis
I agree that it is something that needs to be caught and adapted for, but I disagree that it's a unit test that should do that. As a unit test, the impacts are large and disruptive. As some other tool, it's minimal and still actionable.
_______________________________________________ phobos mailing list [email protected] http://lists.puremagic.com/mailman/listinfo/phobos
