On 18/10/2023 16:25, Nia Espera wrote:
> Device tree files for OnePlus 9 and 9 Pro. Details of supported features
> mentioned in the cover letter for this patch series, but for
> accessibility also repeated here:
>
...
> + /* tp_rst_suspend pinctrl is different per device, don't specify here */
> +
> + tp_irq_active: tp-irq-active-state {
> + pins = "gpio23";
> + function = "gpio";
> + drive-strength = <8>;
> + bias-disable;
> + input-enable;
It does not look like you tested the DTS against bindings. Please run
`make dtbs_check W=1` (see
Documentation/devicetree/bindings/writing-schema.rst or
https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/
for instructions).
We shouldn't need to repeat the same comment twice.
Best regards,
Krzysztof
