Hi Luis, On Sun, Apr 14, 2024 at 02:35:01PM -0600, [email protected] wrote: > From: Luis Garcia <[email protected]> > > It was documented in DT, but not implemented.
Good catch :-) > > Signed-off-by: Ondrej Jirman <[email protected]> > Signed-off-by: Luis Garcia <[email protected]> > --- > drivers/media/i2c/imx258.c | 14 +++++++++++++- > 1 file changed, 13 insertions(+), 1 deletion(-) > > diff --git a/drivers/media/i2c/imx258.c b/drivers/media/i2c/imx258.c > index f0bd72f241e4..5de71cb7c1ae 100644 > --- a/drivers/media/i2c/imx258.c > +++ b/drivers/media/i2c/imx258.c > @@ -699,6 +699,7 @@ struct imx258 { > unsigned int csi2_flags; > > struct gpio_desc *powerdown_gpio; > + struct gpio_desc *reset_gpio; > > /* > * Mutex for serialized access: > @@ -1250,7 +1251,11 @@ static int imx258_power_on(struct device *dev) > regulator_bulk_disable(IMX258_NUM_SUPPLIES, imx258->supplies); > } > > - return ret; > + gpiod_set_value_cansleep(imx258->reset_gpio, 0); > + I think you can remove this new line here. > + usleep_range(400, 500); > + > + return 0; > } > > static int imx258_power_off(struct device *dev) > @@ -1260,6 +1265,7 @@ static int imx258_power_off(struct device *dev) > > clk_disable_unprepare(imx258->clk); > > + gpiod_set_value_cansleep(imx258->reset_gpio, 1); > gpiod_set_value_cansleep(imx258->powerdown_gpio, 1); > > regulator_bulk_disable(IMX258_NUM_SUPPLIES, imx258->supplies); > @@ -1573,6 +1579,12 @@ static int imx258_probe(struct i2c_client *client) > if (IS_ERR(imx258->powerdown_gpio)) > return PTR_ERR(imx258->powerdown_gpio); > > + /* request optional reset pin */ > + imx258->reset_gpio = devm_gpiod_get_optional(&client->dev, "reset", > + GPIOD_OUT_HIGH); > + if (IS_ERR(imx258->reset_gpio)) > + return PTR_ERR(imx258->reset_gpio); > + > /* Initialize subdev */ > v4l2_i2c_subdev_init(&imx258->sd, client, &imx258_subdev_ops); > Looks good to me. Reviewed-by: Tommaso Merciai <[email protected]> > -- > 2.44.0 > >
