Hi, On Mon, Mar 10, 2025 at 07:26:51PM +0200, Sicelo wrote: > Hi Sebastian > > On Fri, Feb 28, 2025 at 11:01:35AM +0100, H. Nikolaus Schaller wrote: > > > It is in linux-next [0]. Not sure if that counts? > > > > Ah, I didn't recognize that (and must admit that I did not search through > > linux-next). Sometimes maintainers close a discussion by telling that it > > has been merged. > > > > Maybe Sebastian can replace it or recommends a fixup. > > > > > I guess the only option now is to submit a follow-up fix? > > How would you like me to correct the bugs I introduced with the patch in > the subject of this email? > > I guess it will either be: > > - submit v2 against linux-power-supply/master or > linux-power-supply/fixes (so the bad commit will be removed from > future history) > - submit a new patch against linux-power-supply/for-next (so the bad > commit will always be in the history) > - use a different solution you suggest > > I apologize for introducing the bug and have taken the time to more > thoroughly test the changes, with help from HNS. I have the patch ready > now, and just need to be sure how to submit it. > > Kind Regards > Sicelo A. Mhlongo
Sorry for the delayed response. You need to prepare a follow-up
patch against power-supply's for-next branch. Dropping the broken
patch would require rebasing the whole branch. The only options
you have are:
1. Revert the original broken patch with a proper long description,
then create a new fix
2. Add a fix on top of the broken fix
Please don't forget to add
Fixes: f3974aca381e ("power: supply: bq27xxx: do not report bogus zero values")
Thanks,
-- Sebastian
signature.asc
Description: PGP signature
