Hi André, Thank you for the patch.
On Wed, May 21, 2025 at 09:34:24PM +0200, André Apitzsch via B4 Relay wrote: > From: André Apitzsch <[email protected]> > > Reorder imx214_parse_fwnode call to reduce goto paths in upcoming > patches. > > No functional change intended. > > Acked-by: Ricardo Ribalda <[email protected]> > Signed-off-by: André Apitzsch <[email protected]> Reviewed-by: Laurent Pinchart <[email protected]> > --- > drivers/media/i2c/imx214.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/media/i2c/imx214.c b/drivers/media/i2c/imx214.c > index > dd7bc45523d8b5fcb3ec95728a6d32c4fddede72..0199195dcb7d12dc2ff253fe3eb77ddbcd0812a9 > 100644 > --- a/drivers/media/i2c/imx214.c > +++ b/drivers/media/i2c/imx214.c > @@ -1261,10 +1261,6 @@ static int imx214_probe(struct i2c_client *client) > struct imx214 *imx214; > int ret; > > - ret = imx214_parse_fwnode(dev); > - if (ret) > - return ret; > - > imx214 = devm_kzalloc(dev, sizeof(*imx214), GFP_KERNEL); > if (!imx214) > return -ENOMEM; > @@ -1295,6 +1291,10 @@ static int imx214_probe(struct i2c_client *client) > return dev_err_probe(dev, PTR_ERR(imx214->regmap), > "failed to initialize CCI\n"); > > + ret = imx214_parse_fwnode(dev); > + if (ret) > + return ret; > + > v4l2_i2c_subdev_init(&imx214->sd, client, &imx214_subdev_ops); > imx214->sd.internal_ops = &imx214_internal_ops; > -- Regards, Laurent Pinchart
