ID:               44443
 Updated by:       [EMAIL PROTECTED]
 Reported By:      [EMAIL PROTECTED]
-Status:           Assigned
+Status:           Closed
 Bug Type:         *Compile Issues
 Operating System: Darwin 9
 PHP Version:      6CVS-2008-03-15 (CVS)
 Assigned To:      gwynne


Previous Comments:
------------------------------------------------------------------------

[2008-03-17 14:56:35] [EMAIL PROTECTED]

Just commit it =)

------------------------------------------------------------------------

[2008-03-15 16:50:38] [EMAIL PROTECTED]

Description:
------------
Darwin 9's sed is broken, causing ./cvsclean to remove a bunch of bogus
file names. Occurs in 5.2, 5.3, and HEAD. Specifically, when catting
.cvsignore, cvsclean gets a list like this:
Makefile.objects Makefile.f agme ts Makefile acco fig.h aclocal.m4
autom4te.cache bsd_co ve ted buildmk.stamp buildco f.stamp co fig.h.i 
co fig.cache co fig.log co fig.status co fig_va s.mk co figu atio -pa se
.c co figu atio -pa se .h co figu atio <and so on>

Patch that fixes in all three:

Index: build/build.mk
===================================================================
RCS file: /repository/php-src/build/build.mk,v
retrieving revision 1.29
diff -u -r1.29 build.mk
--- build/build.mk      15 Feb 2007 20:43:19 -0000      1.29
+++ build/build.mk      15 Mar 2008 16:43:33 -0000
@@ -67,7 +67,7 @@
 
 cvsclean-work:
        @for i in `find . -name .cvsignore`; do \
-               (cd `dirname $$i` 2>/dev/null && rm -rf `cat .cvsignore | grep 
-v
config.nice | sed 's/[\r\n]/ /g'` *.o *.a .libs || true); \
+               (cd `dirname $$i` 2>/dev/null && rm -rf `cat .cvsignore | grep 
-v
config.nice | sed 's/[[:space:]]/ /g'` *.o *.a .libs || true); \
        done
 
 .PHONY: $(ALWAYS) snapshot

Reproduce code:
---------------
$ ls -l config*
$ ./cvsclean
$ ls -l config*

Expected result:
----------------
-rw-r--r--  1 gwynne  gwynne    43499 Nov 29  2005 config.guess
-rw-r--r--  1 gwynne  gwynne    31743 Nov 29  2005 config.sub
-rwxr-xr-x  1 gwynne  gwynne  2872089 Mar 10 10:21 configure
-rw-r--r--  1 gwynne  gwynne    41352 Mar 10 11:17 configure.in

-rw-r--r--  1 gwynne  gwynne    43499 Nov 29  2005 config.guess
-rw-r--r--  1 gwynne  gwynne    31743 Nov 29  2005 config.sub
-rw-r--r--  1 gwynne  gwynne    41352 Mar 10 11:17 configure.in


Actual result:
--------------
-rw-r--r--  1 gwynne  gwynne    43499 Nov 29  2005 config.guess
-rw-r--r--  1 gwynne  gwynne    31743 Nov 29  2005 config.sub
-rwxr-xr-x  1 gwynne  gwynne  2872089 Mar 10 10:21 configure
-rw-r--r--  1 gwynne  gwynne    41352 Mar 10 11:17 configure.in

-rw-r--r--  1 gwynne  gwynne    43499 Nov 29  2005 config.guess
-rw-r--r--  1 gwynne  gwynne    31743 Nov 29  2005 config.sub
-rwxr-xr-x  1 gwynne  gwynne  2872089 Mar 10 10:21 configure
-rw-r--r--  1 gwynne  gwynne    41352 Mar 10 11:17 configure.in



------------------------------------------------------------------------


-- 
Edit this bug report at http://bugs.php.net/?id=44443&edit=1

Reply via email to