ID:               45456
 Updated by:       [EMAIL PROTECTED]
 Reported By:      Keisial at gmail dot com
-Status:           Open
+Status:           Assigned
 Bug Type:         Compile Warning
 Operating System: Windows
 PHP Version:      5.3CVS-2008-07-08 (snap)
-Assigned To:      
+Assigned To:      pajoye
 New Comment:

Pierre, you're working on Windows stuff these days, please have a look,
thanks.


Previous Comments:
------------------------------------------------------------------------

[2008-07-08 13:46:19] Keisial at gmail dot com

Description:
------------
_WIN32_WINNT macro can be defiend before including windows headers to
specify the minimun windows nt version to support (usually to unhide
prototypes not available on previous versions).

It is used like this on TSRM/readdir.h before including windows.h
So far, so good.

However, due to include order, windows.h is already included before,
defining _WIN32_WINNT by itself and thus it doesn't do anything. So the
define should either be removed (if it's not needed), or moved before.

Reproduce code:
---------------
_WIN32_WINNT is defined on TSRM/readdir.h:10:
main/php.h:405->TSRM/tsrm_virtual_cwd.h:55->readdir.h

windows.h was already included by:
main/php.h:34->Zend/zend.h:53->zend_config.w32.h:39
(in fact winsock2.h at zend_config.w32.h:38 is already including it
before the real one)



------------------------------------------------------------------------


-- 
Edit this bug report at http://bugs.php.net/?id=45456&edit=1

Reply via email to