ID: 48619 Comment by: andy at webtatic dot com Reported By: andy at webtatic dot com Status: Assigned Bug Type: IMAP related Operating System: CentOS 5.3 i386 PHP Version: 5.2.10 Assigned To: pajoye New Comment:
oops, should have used | not & :) it prob makes a bit more sense then http://pastebin.com/m33a7819b Previous Comments: ------------------------------------------------------------------------ [2009-06-20 21:58:44] andy at webtatic dot com sorry for intruding again, but I thought this patch might be more ideal for the imap_sort, as it'd be hard to compare the flag when its still in its PHP wrapper. http://pastebin.com/m2325a4b4 ------------------------------------------------------------------------ [2009-06-20 21:36:30] andy at webtatic dot com ah right ok. yep, it doesn't really make sense to add in a constant that can only be used (or not used in this case) to create a memory leak. ------------------------------------------------------------------------ [2009-06-20 21:33:26] paj...@php.net Sorry, I should have been more clear, this patch is not tested (did not even compile it, no vc at hand :), it was only for the idea. Yes, the free mode is also a constant as well as some other, so a bit comparison is necessary. That being said, I'm not sure to understand why we exposed SE_FREE in the 1st place... ------------------------------------------------------------------------ [2009-06-20 21:26:44] andy at webtatic dot com SE_FREE is also a PHP constant, so the user (for some reason), might pass in the flag SE_FREE | SE_UID, which a direct != will not match SE_FREE on, causing the same issue. You should probably do a bitwise check for the flag in your case. ------------------------------------------------------------------------ [2009-06-20 21:15:49] paj...@php.net I made one already too, http://pastebin.com/m22b58a19 I prefer this way as there is no ambiguity, I also fixed the other locations where a similar situation can happen. I have to merge into head and it will committed. Thanks for your work! ------------------------------------------------------------------------ The remainder of the comments for this report are too long. To view the rest of the comments, please view the bug report online at http://bugs.php.net/48619 -- Edit this bug report at http://bugs.php.net/?id=48619&edit=1