ID: 50075
Updated by: [email protected]
Reported By: RQuadling at GMail dot com
Status: Open
Bug Type: Feature/Change Request
Operating System: Irrelevant
PHP Version: 5.3.1RC3
New Comment:
This patch is not correct, because it doesn't take care of daylight
savings time nor should "invert" being taken into account as it's
already a seperate field. I wouldn't call it "diff" either, but
"seconds" just like there is "days".
Previous Comments:
------------------------------------------------------------------------
[2009-11-04 14:31:46] RQuadling at GMail dot com
Description:
------------
The output of DateInterval->diff() currently shows the breakdown of
the
difference (y, m, d, h, i, s, days, invert).
Which is fine. But I'd like to be able to have the number of seconds
difference.
The following patch adds a new entry to the output: diff.
It is a straight calculation of the seconds based upon days, h, i and
s,
and takes into consideration invert.
The patch below is the same for branch/5_3 and trunk.
I think this patch and the DateInterval object comparison patch
reported in Bug#49914 by aharvey would be good additions.
Regards,
Richard.
Reproduce code:
---------------
Index: php_date.c
===================================================================
--- php_date.c (revision 290198)
+++ php_date.c (working copy)
@@ -2245,6 +2245,16 @@
PHP_DATE_INTERVAL_ADD_PROPERTY("s", s);
PHP_DATE_INTERVAL_ADD_PROPERTY("invert", invert);
PHP_DATE_INTERVAL_ADD_PROPERTY("days", days);
+
+ MAKE_STD_ZVAL(zv);
+ ZVAL_LONG(zv, ((((((
+ intervalobj->diff->days * 24) +
+ intervalobj->diff->h) * 60) +
+ intervalobj->diff->i) * 60) +
+ intervalobj->diff->s) * (
+ intervalobj->diff->invert ? -1 : 1)
+ );
+ zend_hash_update(props, "diff", 5, &zv, sizeof(zval), NULL);
return props;
}
------------------------------------------------------------------------
--
Edit this bug report at http://bugs.php.net/?id=50075&edit=1
