ID:               50727
 Updated by:       j...@php.net
 Reported By:      lodeclaassen at gmail dot com
-Status:           Assigned
+Status:           Closed
 Bug Type:         Reproducible crash
 Operating System: Debian Linux
 PHP Version:      5.2.12
 Assigned To:      mysql


Previous Comments:
------------------------------------------------------------------------

[2010-02-01 11:37:49] s...@php.net

Automatic comment from SVN on behalf of andrey
Revision: http://svn.php.net/viewvc/?view=revision&revision=294298
Log: backport checks from 5.3 which fix one known segfault,
and maybe others unknown.
Bug #50727      Accesing mysqli->affected_rows on no connection causes
segfault

------------------------------------------------------------------------

[2010-01-12 01:28:50] lodeclaassen at gmail dot com

Thanks!
Do you know what properties/functions are affected apart from
affected_rows? Or is that the only one?

My current fix/workaround was to test isset(affected_rows), but I've
noticed that isset(insert_id) fails even if it has a number.

------------------------------------------------------------------------

[2010-01-12 00:40:27] johan...@php.net

Fixed in 5.3. Can reproduce in 5.2.

A simple fix for this might be

Index: ext/mysqli/mysqli_prop.c
===================================================================
--- ext/mysqli/mysqli_prop.c    (revision 293046)
+++ ext/mysqli/mysqli_prop.c    (working copy)
@@ -162,7 +162,7 @@
 
        mysql = (MY_MYSQL *)((MYSQLI_RESOURCE *)(obj->ptr))->ptr;
        
-       if (!mysql) {
+       if (!mysql || !mysql->mysql) {
                ZVAL_NULL(*retval);
        } else {
                CHECK_STATUS(MYSQLI_STATUS_VALID);


Untested and other properties might be affected - might be better to
backport the fix from 5.3.

------------------------------------------------------------------------

[2010-01-12 00:11:21] lodeclaassen at gmail dot com

Description:
------------
I open a mysqli connection that failes (in the tested case wrong
password). After that when I try to get the affected rows
(mysqli->affected_rows) PHP exits and I only get a blank screen.

The configure command from phpinfo:
'./configure' '--with-apxs2' '--with-curl=/usr/local/lib' '--with-gd'
'--enable-gd-native-ttf' '--with-ttf' '--with-gettext'
'--with-jpeg-dir=/usr/local/lib' '--with-freetype-dir=/usr/local/lib'
'--with-kerberos' '--with-openssl' '--with-mcrypt' '--with-mhash'
'--with-mysql=/usr/local/mysql'
'--with-mysqli=/usr/local/mysql/bin/mysql_config'
'--with-pdo-mysql=/usr/local/mysql' '--with-pear'
'--with-png-dir=/usr/local/lib' '--with-zlib'
'--with-zlib-dir=/usr/local/lib' '--enable-zip'
'--with-iconv=/usr/local' '--enable-bcmath' '--enable-calendar'
'--enable-ftp' '--enable-magic-quotes' '--enable-sockets'
'--enable-mbstring'

Other settings I don't know, I don't operate the host.

Reproduce code:
---------------
<?php
echo 'startup<br />';

if (isset($_GET['try']) && $_GET['try'] == 1) {
        $connection = new mysqli('localhost', 'user', 'wrong password',
'SomeExistingTable');
        $connection->query("SELECT `id` FROM `SomeExistingTable` LIMIT 1");
        echo 'affected rows: '.$connection->affected_rows.'<br />';
}

echo 'ending<br />';
?>

Expected result:
----------------
If I request the file with ?try=0 I expect:

startup
ending

When I request ?try=1 I get nothing, a blank screen.

Actual result:
--------------
With ?try=1 I expect to see:

startup
affected rows: 
ending


------------------------------------------------------------------------


-- 
Edit this bug report at http://bugs.php.net/?id=50727&edit=1

Reply via email to