Edit report at http://bugs.php.net/bug.php?id=51740&edit=1

 ID:               51740
 User updated by:  dave dot mulford at gmail dot com
 Reported by:      dave dot mulford at gmail dot com
 Summary:          acinclude.m4 macro PHP_CHECK_SIZEOF is not properly
                   quoted
 Status:           Open
 Type:             Bug
 Package:          Compile Warning
 Operating System: gentoo linux 2.6.30
 PHP Version:      5.3SVN-2010-05-04 (snap)

 New Comment:

I could not get the system to allow me to upload my patch file, so here
it is, 

in plain text.



--- acinclude.m4.original       2010-05-04 13:48:26.000000000 +0000

+++ acinclude.m4        2010-05-04 13:48:37.000000000 +0000

@@ -1095,7 +1095,7 @@

 dnl

 dnl PHP_CHECK_SIZEOF(type, cross-value, extra-headers)

 dnl

-AC_DEFUN(PHP_CHECK_SIZEOF, [

+AC_DEFUN([PHP_CHECK_SIZEOF], [

   AC_MSG_CHECKING([size of $1])

   _PHP_CHECK_SIZEOF($1, $2, $3, [

     AC_DEFINE_UNQUOTED([SIZEOF_]translit($1,a-z,A-Z_),
[$]php_cv_sizeof_[]$1, 

[Size of $1])


Previous Comments:
------------------------------------------------------------------------
[2010-05-04 16:10:23] dave dot mulford at gmail dot com

Description:
------------
When building an extension I've written, aclocal displays a warning that
the 

macro PHP_CHECK_SIZEOF is "underquoted." I have confirmed this by
checking line 

1098 of the acinclude.m4 file that gets copied after phpize is run. 



According to the autoconf documentation, all macros should be surrounded
by 

quotes.
http://www.gnu.org/software/autoconf/manual/autoconf.html#Macro-

Definitions

Expected result:
----------------
No warnings should be displayed when the aclocal command is executed.

Actual result:
--------------
acinclude.m4:1098: warning: underquoted definition of PHP_CHECK_SIZEOF

acinclude.m4:1098:   run info '(automake)Extending aclocal'

acinclude.m4:1098:   or see 

http://sources.redhat.com/automake/automake.html#Extending-aclocal


------------------------------------------------------------------------



-- 
Edit this bug report at http://bugs.php.net/bug.php?id=51740&edit=1

Reply via email to