Edit report at http://bugs.php.net/bug.php?id=53430&edit=1
ID: 53430
Updated by: johan...@php.net
Reported by: 128bitencrypted at gmail dot com
Summary: ts_free_thread() frees only temporary in multiple
parallel threads
-Status: Open
+Status: Bogus
Type: Bug
Package: Other web server
Operating System: Windows
PHP Version: Irrelevant
Block user comment: N
Private report: N
New Comment:
This is no Bug but a request for support. Please ask on pecl-dev or maye
the internals-win list.
A few remarks anyways: I don't know Windows threading models, in general
you have to make sure that PHP and the environment use compatible
threading models. PHP has some true global data which is shared across
all threads. So having higher memory usage till PHP is shut down
completely is expected.
In general TSRM isn't encouraged that much as it causes quite some
overhead .. but as said: The bug tracker is no place to discuss your
custom SAPIs.
Previous Comments:
------------------------------------------------------------------------
[2010-11-30 20:39:21] 128bitencrypted at gmail dot com
Description:
------------
I created my own php sapi 1 year ago and it was only single threaded.
Now I tried to make it multi-threaded by using TSRM.
I got 1 thread starting up and shutting down the TSRM and my module and
many other threads executing requests. You can take a look at this
abstract example here:
DWORD WINAPI test_thread(void*)
{
TSRMLS_FETCH() // a lot of memory is allocated here
// execute the request (just core functions written here)
php_request_startup(TSRMLS_C);
php_execute_script(fh, TSRMLS_C);
php_request_shutdown(TSRMLS_C);
ts_free_thread(); // I tried to free the memory allocated through
TSRMLS_FETCH() here
}
int main()
{
tsrm_startup(1, 1, 0, NULL);
sapi_startup(&my_php_sapi);
php_module_startup(&my_php_sapi, NULL, 0);
sapi_activate(TSRMLS_C);
// start 25 threads running "test_thread()" here
// call module/sapi shutdown functions
tsrm_shutdown(); // all memory gets freed here
}
The request threads work fine but I noticed that all the copies
allocated through TSRMLS_FETCH() last in the memory until
tsrm_shutdown() gets executed. So I browsed the web and found that
ts_free_thread() should solve it. But now here's the problem:
When I'm executing only 1 request thread at a time, everything works
fine and ts_free_thread() frees all resources. But when I run multiple
threads at the same time the memory gets up and down until all threads
finished. But after all threads exited the memory grows up enormous.
This is what happens:
- start 25 threads -- memory: ~25.000 k
- threads finish one by one -- memory: ~25.000 k --> ~4.000 k
- all threads finished -- memory: ~60.000 k
I was using php 5.2.9 and now tried the same with the latest stable
5.3.3 release but the problem still resists.
I couldn't really locate the problem yet.
Expected result:
----------------
memory stays at ~4.000 k when all threads finish
Actual result:
--------------
memory grows suddenly about more that 100 percent
------------------------------------------------------------------------
--
Edit this bug report at http://bugs.php.net/bug.php?id=53430&edit=1
