Edit report at http://bugs.php.net/bug.php?id=53854&edit=1

 ID:                 53854
 Updated by:         rquadl...@php.net
 Reported by:        rquadl...@php.net
 Summary:            Missing constants for compression type.
 Status:             Assigned
 Type:               Bug
 Package:            Zip Related
 Operating System:   n/a
 PHP Version:        5.3SVN-2011-01-27 (SVN)
 Assigned To:        aharvey
 Block user comment: N
 Private report:     N

 New Comment:

As the compression mechanisms are stored within the zip file itself, it
isn't 

necessarily a requirement for php_zip to support
compression/decompression of these 

types, just identification.



Using WinZip V15.0, I've created an archive with CM_PPMD, CM_LZMA,
CM_BZIP and 

CM_WAVPACK compressions.



Still looking for LZ77 and Terse.



The compression types are correctly identified by php_zip, so having the
constants 

makes sense to me.



I'll update the documentation to say that whilst identification of these
types is 

performed, compression and decompression of these types is not currently
supported.


Previous Comments:
------------------------------------------------------------------------
[2011-01-28 07:43:12] paj...@php.net

Are you sure all compression modes are implemented? I don't think they
are, afair 

that's also why I did not add them.

------------------------------------------------------------------------
[2011-01-28 05:19:55] ahar...@php.net

This bug has been fixed in SVN.

Snapshots of the sources are packaged every three hours; this change
will be in the next snapshot. You can grab the snapshot at
http://snaps.php.net/.
 
Thank you for the report, and for helping us make PHP better.



------------------------------------------------------------------------
[2011-01-28 05:19:43] ahar...@php.net

Automatic comment from SVN on behalf of aharvey
Revision: http://svn.php.net/viewvc/?view=revision&revision=307807
Log: Fixed bug #53854 (Missing constants for compression type). Patch by
Richard
Quadling.

------------------------------------------------------------------------
[2011-01-27 14:55:29] rquadl...@php.net

The following patch has been added/updated:

Patch Name: missing_zip_constants.patch
Revision:   1296136529
URL:       
http://bugs.php.net/patch-display.php?bug=53854&patch=missing_zip_constants.patch&revision=1296136529

------------------------------------------------------------------------
[2011-01-27 14:54:59] rquadl...@php.net

Description:
------------
ext/zip internally uses several constants to identify the nature of the
compressed 

content.



Not all of these are exposed, though one of them is documented 

(ZipArchive::CM_BZIP2).



The attached patch for ext/zip/php_zip.c adds the missing constants.



Once this is committed, I can update the documentation with the others
(LZMA, 

TERSE, LZ77, WAVPACK and PPMD).



------------------------------------------------------------------------



-- 
Edit this bug report at http://bugs.php.net/bug.php?id=53854&edit=1

Reply via email to