Edit report at https://bugs.php.net/bug.php?id=42060&edit=1

 ID:                 42060
 Updated by:         scott...@php.net
 Reported by:        iarenuno at eteo dot mondragon dot edu
 Summary:            [PATCH] LDAP: Add pagedResults support and more
 Status:             Feedback
 Type:               Feature/Change Request
 Package:            *General Issues
 Operating System:   *
 PHP Version:        5CVS, 6CVS (2008-11-01)
 Assigned To:        pajoye
 Block user comment: N
 Private report:     N

 New Comment:

I fixed the tests, singular made more sense.


Previous Comments:
------------------------------------------------------------------------
[2011-08-24 05:54:58] jeanseb at au-fil-du dot net

With Pierre we agreed to use singular form.

Could someone with karma fix this ?



https://bugs.php.net/bug.php?id=42060&edit=2#1288788479

------------------------------------------------------------------------
[2011-08-23 15:55:40] peng1can at gmail dot com

Is this plural/singular typo the only thing holding this patch up?  Can't a 
choice just be made and move on?

------------------------------------------------------------------------
[2011-06-02 11:48:21] sala...@php.net

The implemented functions are currently called 
"ldap_control_paged_result[_response]" but the tests try to use the plural 
"results" names.  Which are we going to keep, Scott is there any reason you 
chose 
the singular names?

------------------------------------------------------------------------
[2011-05-19 19:42:24] scott...@php.net

I applied the rename patch and tidied up the code a little.

Anything else that needs done here?

------------------------------------------------------------------------
[2011-05-19 19:41:24] scott...@php.net

Automatic comment from SVN on behalf of scottmac
Revision: http://svn.php.net/viewvc/?view=revision&revision=311264
Log: Tidy up ldap paging code and rename the API as discussed in #42060

------------------------------------------------------------------------


The remainder of the comments for this report are too long. To view
the rest of the comments, please view the bug report online at

    https://bugs.php.net/bug.php?id=42060


-- 
Edit this bug report at https://bugs.php.net/bug.php?id=42060&edit=1

Reply via email to