Edit report at https://bugs.php.net/bug.php?id=62840&edit=1

 ID:                 62840
 User updated by:    bert at becoded dot be
 Reported by:        bert at becoded dot be
 Summary:            Add sort flag to ArrayObject::ksort
 Status:             Closed
 Type:               Feature/Change Request
 Package:            SPL related
 PHP Version:        5.4.5
 Assigned To:        laruence
 Block user comment: N
 Private report:     N

 New Comment:

Thx for the quick implementation!


Previous Comments:
------------------------------------------------------------------------
[2012-08-21 06:24:12] larue...@php.net

yes, I noticed that, just I thought it was acceptable, there is the same issue 
in 
uasort.

------------------------------------------------------------------------
[2012-08-21 05:59:06] reeze dot xia at gmail dot com

cool, I implemented it last night, but missing a better test case.
I think the error message isn't correct, so I didn't sent it.

you could see that, the warning message is not really exactly correct.
It just a proxy to call asort($obj, $flag) if the $flag is not valid.
It complained about the 2 parameter is not valid but not the first parameter.

$obj->sort('adfsd');  // 1
sort($ar, 'adfds');   // 2

------------------------------------------------------------------------
[2012-08-21 05:30:45] larue...@php.net

This bug has been fixed in SVN.

Snapshots of the sources are packaged every three hours; this change
will be in the next snapshot. You can grab the snapshot at
http://snaps.php.net/.

 For Windows:

http://windows.php.net/snapshots/
 
Thank you for the report, and for helping us make PHP better.



------------------------------------------------------------------------
[2012-08-21 05:30:07] larue...@php.net

hmm, after a quick look, this will be very easy to implemented. then I did it. 
:)

------------------------------------------------------------------------
[2012-08-21 00:59:20] reeze dot xia at gmail dot com

Sounds reasonable to me I am working on a patch for this request.
Will send a pull request later.

Thanks

------------------------------------------------------------------------


The remainder of the comments for this report are too long. To view
the rest of the comments, please view the bug report online at

    https://bugs.php.net/bug.php?id=62840


-- 
Edit this bug report at https://bugs.php.net/bug.php?id=62840&edit=1

Reply via email to