Edit report at https://bugs.php.net/bug.php?id=62343&edit=1
ID: 62343
Comment by: valentiny510 at yahoo dot es
Reported by: valentiny510 at yahoo dot es
Summary: Show class_alias In get_declared_classes( )
Status: Assigned
Type: Feature/Change Request
Package: Class/Object related
Operating System: XP
PHP Version: 5.4.4
Assigned To: dmitry
Block user comment: N
Private report: N
New Comment:
pajoye said: "Aliases are not declared classes but ... aliases :)"
With this comment I must understand that if the aliases are not declared
classes, that aliases must NOT be included in the get_declared_classes( ) also
..
right ? .. see u smiling :D
Previous Comments:
------------------------------------------------------------------------
[2012-06-25 08:00:27] dmi...@php.net
I would say the patch is bad, because all the returned class names will be
lowercased. However, it's possible to improve the patch by comparison of
lowercasesd ce->name and hash_key->arKey. In case they are equal we can return
ce->name and hash_key->arKey otherwise.
I would also prefer not to extend functionality of internal functions without a
big reason (user_only argument).
------------------------------------------------------------------------
[2012-06-22 16:25:50] larue...@php.net
okey, thanks :)
------------------------------------------------------------------------
[2012-06-22 09:37:10] paj...@php.net
Also bring that on internals please. There are room for discussions here.
------------------------------------------------------------------------
[2012-06-22 09:33:43] paj...@php.net
Aliases are not declared classes but ... aliases :)
I don't think it should be shown through that.
However, using an optional argument, it could then return:
Array
(
['a'] => NULL
['b'] => 'a'
)
for example.
------------------------------------------------------------------------
[2012-06-22 09:31:45] larue...@php.net
Dmitry, could you please review this patch? there is one thing I am not sure
is,
there was a :
if ((hash_key->nKeyLength==0 || hash_key->arKey[0]!=0)
I am not sure about the first condition, IMO the key should not be a number in
CG/EG(class_table), so I remove that condition, did I miss something?
thanks
------------------------------------------------------------------------
The remainder of the comments for this report are too long. To view
the rest of the comments, please view the bug report online at
https://bugs.php.net/bug.php?id=62343
--
Edit this bug report at https://bugs.php.net/bug.php?id=62343&edit=1
