Edit report at https://bugs.php.net/bug.php?id=63242&edit=1
ID: 63242
Updated by: re...@php.net
Reported by: pascal dot chevrel at free dot fr
Summary: Default error page in PHP built-in web server uses
outdated html/css
Status: Open
Type: Feature/Change Request
Package: Built-in web server
Operating System: Linux
PHP Version: 5.4.7
Block user comment: N
Private report: N
New Comment:
@Pascal,
I like the idea to make it more modern, I just think the color you choose it
not
well consist with PHP's blue color and visual identity.
Previous Comments:
------------------------------------------------------------------------
[2012-10-09 12:02:24] pascal dot chevrel at free dot fr
I just attached an updated patch that restores the blue color.
You can see the result here:
http://chevrel.org/images/phpbugs/bug63242v2.png
I also compiled php locally and ran the tests, there were 2 tests failing
because of the new patch, I updated these two tests in my patch.
Tell me if you need updates to this patch, thanks.
------------------------------------------------------------------------
[2012-10-09 09:40:50] pascal dot chevrel at free dot fr
@laruence
Thanks, I will do that this afternoon. Is that ok if I just add back the blue
background color of do you want the page to remain strictly identical to what
it is now? (currently the title and paragraph are not aligned, the title also
has no padding and sticks to the blue border /ex).
------------------------------------------------------------------------
[2012-10-09 09:34:33] larue...@php.net
sorry, should be:
it will be better if you can improve the skeleton, but keep the "looks"
------------------------------------------------------------------------
[2012-10-09 09:34:02] larue...@php.net
@pascal, thanks
it will be better if you can improve the skeleton keep the "looks"
------------------------------------------------------------------------
[2012-10-09 08:37:57] pascal dot chevrel at free dot fr
Reeze, not sure I understand what you mean. For sure, I am in no way saying
that the integrated web server should be used in production.
You seem to be of the opinion that since it is not targetting production, it is
ok that it is using obsolete HTML/CSS and looks like a 404 page from the 90's,
I disagree, there is no reason to use complex sub-quality HTML/CSS, especially
since it gives poor visual result.
My patch simplifies the code used (less lines of code) while making the error
page a bit more decent in terms of layout.
I am happy to make compromises on this patch and revert the color to use the
same blue color as before if you wish, using correct typography/alignment and
simpler html/css code in the source code would already be a win for both
consumers (web developpers that see this page during their developement) and
the code base I think.
------------------------------------------------------------------------
The remainder of the comments for this report are too long. To view
the rest of the comments, please view the bug report online at
https://bugs.php.net/bug.php?id=63242
--
Edit this bug report at https://bugs.php.net/bug.php?id=63242&edit=1
