Edit report at https://bugs.php.net/bug.php?id=55701&edit=1
ID: 55701
Comment by: ivanderberg at hostnet dot nl
Reported by: b...@php.net
Summary: GlobIterator throws LogicException with message 'The
parent constructor was not
Status: Assigned
Type: Bug
Package: SPL related
Operating System: Linux, OSX
PHP Version: 5.3.8
Assigned To: cataphract
Block user comment: N
Private report: N
New Comment:
I can confirm what "[2012-03-19 21:24 UTC] maciej dot sz at gmail dot com" said
in a more simplistic way. This class fails in my current version (PHP 5.3.14
(cli) (built: Jun 19 2012 07:35:36)) on $this->touchLockFile(...)
As I really need $file before calling the parent constructor, I have no other
option than making it static
<?php
/**
* @author Iltar van der Berg <ivanderb...@hostnet.nl>
*/
class Lock extends \SplFileObject
{
/**
* @param string $file_name
* @param string $open_mode
* @param Filesystem $filesystem
* @param string $lock_directory
*/
public function __construct($file_name, $open_mode = 'r', Filesystem
$filesystem = null, $lock_directory = '/var/lock')
{
$filesystem = $filesystem ?: new Filesystem();
$file = $this->touchLockFile($file_name, $lock_directory, $filesystem);
parent::__construct($file, $open_mode);
}
/**
* Returns true if the lock is placed, false if unable to
*
* @return boolean
*/
public function lock()
{
return $this->flock(LOCK_EX | LOCK_NB);
}
/**
* Returns true if the lock is released
*
* @return bool
*/
public function release()
{
return $this->flock(LOCK_UN);
}
/**
* Attempts to create a lock file for a given filename and directory
* it will return a string if the file is touched
*
* @param string $file_name
* @param string $lock_directory
* @param Filesystem $filesystem
* @return string
*/
private function touchLockFile($file_name, $lock_directory, Filesystem
$filesystem)
{
$lock_file_path = explode('/', $file_name);
$lock_file = array_pop($path);
$path = empty($lock_file_path)
? "$lock_directory/$lock_file"
: $lock_directory . implode('/', $lock_file_path);
$lock_file = "$path/$lock_file.lock";
if(!$filesystem->exists($path) || !is_dir($path)) {
$filesystem->mkdir($path, 0733);
}
// some modes create this file already, but we force it in
// that way the lock file always exists no matter what mode
$filesystem->touch($lock_file);
return $lock_file;
}
}
?>
Previous Comments:
------------------------------------------------------------------------
[2012-03-19 21:24:42] maciej dot sz at gmail dot com
Not sure if this is the same issue, but I've experienced something very similar
when extending SplFileObject (see Script 1 below). This might seem to be of
very
little importance, as no one would ever want to extend this class in that way.
But with the introduction of traits this became a real problem, becouse using
trait methods that share the same name with a SplFileObject method causes to
throw the mentioned LogicException. This happens when the method is used in
constructor prior to calling the parent constructor even if the trait method is
aliased (see Script 2 below).
Script 1:
--------------
<?php
class MyFileObject extends \SplFileObject
{
public function __construct($fname)
{
/**
* This throws LogicException despite of that we have
* overloaded the getRealPath method making it independent
* of the object state.
*/
$new_fname = $this->getRealPath();
parent::__construct($fname);
}
public function getRealPath()
{
return '/tmp/foo.txt';
}
}
$f1 = new MyFileObject(__FILE__);
Script 2
--------------
<?php
trait NewFileTrait
{
public function getRealPath()
{
return __FILE__ . '.new';
}
}
class MyFileObject extends \SplFileObject
{
use NewFileTrait {
/**
* The method getRealPath is defined in SplFileObject,
* so we'll use alias:
*/
NewFileTrait::getRealPath as newFileGetRealPath;
}
public function __construct($fname)
{
/**
* This throws LogicException despite using aliased method.
* This should not be happening, as we are not using any
* methods of the SplFileObject class, just the aliased method
* of our trait which happens to share the same name with
* a SplFileObject method.
*/
$new_fname = $this->newFileGetRealPath();
parent::__construct($new_fname);
}
}
$f1 = new MyFileObject(__FILE__);
------------------------------------------------------------------------
[2011-09-15 13:42:30] b...@php.net
Description:
------------
Basic functionality doesn't work because it seems as the GlobIterator might
needs
some changes to work with this commit:
http://marc.info/?l=php-cvs&m=130188548616717
Test script:
---------------
<?php
$g = new \GlobIterator(__DIR__ . '/*');
do {
$g->next();
} while($g->valid());
Expected result:
----------------
Empty output
Actual result:
--------------
PHP Fatal error: Uncaught exception 'LogicException' with message 'The parent
constructor
was not called: the object is in an invalid state ' in /private/tmp/x.php:6
Stack trace:
#0 /private/tmp/x.php(6): SplFileInfo->_bad_state_ex()
#1 {main}
thrown in /private/tmp/x.php on line 6
Fatal error: Uncaught exception 'LogicException' with message 'The parent
constructor was not
called: the object is in an invalid state ' in /private/tmp/x.php:6
Stack trace:
#0 /private/tmp/x.php(6): SplFileInfo->_bad_state_ex()
#1 {main}
thrown in /private/tmp/x.php on line 6
------------------------------------------------------------------------
--
Edit this bug report at https://bugs.php.net/bug.php?id=55701&edit=1
