Edit report at https://bugs.php.net/bug.php?id=62639&edit=1
ID: 62639
Updated by: larue...@php.net
Reported by: alexshock at yandex dot ru
Summary: XML structure broken
Status: Assigned
Type: Bug
Package: SimpleXML related
Operating System: debian 6.0.5
PHP Version: 5.4.5
Assigned To: acurioso
Block user comment: N
Private report: N
New Comment:
I think we should revert the previous fix at now, since this new bug is more
critical than the previous one.
and I think the key problem there is that we can not tell iterating from
convert_to_array in the sxe_get_prop_hash
without that, I don't think we can get a good fix for the 034.phpt
Previous Comments:
------------------------------------------------------------------------
[2013-02-18 21:21:48] sala...@php.net
Related To: Bug #62203
------------------------------------------------------------------------
[2012-07-30 01:57:05] willfi...@php.net
I think that would make more sense. Thanks, Andrew.
------------------------------------------------------------------------
[2012-07-30 00:58:13] acuri...@php.net
I can confirm that reverting that patch does fix the bug; however, it causes
the original test to fail again:
=====================================================================
FAILED TEST SUMMARY
---------------------------------------------------------------------
SimpleXML: cast to array [ext/simplexml/tests/034.phpt]
Bug #51615 (PHP crash with wrong HTML in SimpleXML)
[ext/simplexml/tests/bug51615.phpt]
=====================================================================
See: ext/simplexml/tests/034.phpt for more information.
Ignore bug51615.phpt for now. That is just a side effect of test 34.
I would actually prefer if I could take the first stab at this bug myself since
it was clearly introduced in my code. I'd be hesitate to just revert the
changes since that would break test 34.
------------------------------------------------------------------------
[2012-07-29 23:44:17] acuri...@php.net
After reverting locally do all the unit test cases for SimpleXML still pass?
This was not the case prior to the patch (one test was failing).
I'll work on reverting the change locally on my end tonight and see if I can
reproduce the bug and fix.
------------------------------------------------------------------------
[2012-07-29 23:16:31] willfi...@php.net
Andrew -
Would you mind taking a look at this? I reverted
1e3b32c777829f61fa9a18278e0647e9112d96ea locally, and array typecasting works
fine without the patch. Also, this patch causes the last child in an element
to
be skipped in the case pointed out in this
report. I wanted to get your input before I move forward with any changes.
------------------------------------------------------------------------
The remainder of the comments for this report are too long. To view
the rest of the comments, please view the bug report online at
https://bugs.php.net/bug.php?id=62639
--
Edit this bug report at https://bugs.php.net/bug.php?id=62639&edit=1
