Edit report at https://bugs.php.net/bug.php?id=44522&edit=1

 ID:                 44522
 Comment by:         lang at b1-systems dot de
 Reported by:        mail2lv at yahoo dot com
 Summary:            http upload max_limits and file above 2GB
 Status:             Open
 Type:               Feature/Change Request
 Package:            *Web Server problem
 Operating System:   All
 PHP Version:        5.2.5
 Block user comment: N
 Private report:     N

 New Comment:

Newest Mailing List feedback applied.
Pull Request attached.
Please pull or comment in github or here.


Previous Comments:
------------------------------------------------------------------------
[2013-04-19 20:21:34] azet at azet dot org

Could you please add this patch? It MIGHT make seem PHP less an embarrassing 
language than it is already.

Sincerely,
The Internet

------------------------------------------------------------------------
[2013-04-19 09:37:22] scroogie at scroogie dot de

In my opinion this is quite an issue. We faced it at an intranet side yesterday.
Due to the cast to int at 
https://github.com/php/php-src/blob/master/main/rfc1867.c#L901 it also has 
weird side effects, like setting 4G will equal 0 and disable the size check 
(see https://github.com/php/php-src/blob/master/main/rfc1867.c#L1031), 5G equal 
1G etc.

------------------------------------------------------------------------
[2012-03-26 04:02:16] jason at infininull dot com

I have re-rolled the patch against HEAD 
(b4d078f18c950a4bf7e136443586e348bd54f40c) 
and attached it to this request.

------------------------------------------------------------------------
[2012-03-24 18:42:45] jason at infininull dot com

I was recently bitten by this bug too.  The patch needed a little updating for 
11.04 and I also found a couple of other issues.  1) Uploads only work if 
upload_max_filesize = 0 and 2) The $_FILES[*]['size'] value is an overflowed 
integer.  The attached patch fixes these issues.  I am currently in the process 
of 
re-rolling the patch against HEAD on master to get this in to upstream.

------------------------------------------------------------------------
[2012-02-23 19:14:51] s...@php.net

It's probably too late for 5.4, but would be OK for trunk. The patch however 
needs to be cleaned up (no IGNORE vars, etc.) and changing signature for 
zend_atoi may not be safe if any code out there presumes it returns int 
(integer 
overflow). Also, no reason to use signed long there where we used unsigned long.

------------------------------------------------------------------------


The remainder of the comments for this report are too long. To view
the rest of the comments, please view the bug report online at

    https://bugs.php.net/bug.php?id=44522


-- 
Edit this bug report at https://bugs.php.net/bug.php?id=44522&edit=1

Reply via email to